Bug 150061

Summary:	FILEOPEN: DOCX: Incorrect images displayed
Product:	LibreOffice	Reporter:	Xisco Faulí <xiscofauli>
Component:	Writer	Assignee:	Justin L <jluth>
Status:	VERIFIED FIXED
Severity:	normal	CC:	79045_79045, aron.budea, gerald, gulsah.kose, jluth, rb.henschel, telesto, vmiklos, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.3.1.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=141652 https://bugs.documentfoundation.org/show_bug.cgi?id=134210
Whiteboard:
Crash report or crash signature:		Regression By:	Justin Luth
Attachments:	Comparsion MSO vs LibreOffice 7.5 150061_71.jpg: LO 7.2 before commit b90a67838e189f3aee6a50724c78c0a50d416970

Description Xisco Faulí 2022-07-19 11:54:57 UTC

Created attachment 181325 [details]
Comparsion MSO vs LibreOffice 7.5

Steps to reproduce:
1. Open attachment 49792 [details] from bug 39722 a few times

-> Every time the document is open, the images are different. See comparison

Reproduced in

Version: 7.5.0.0.alpha0+ / LibreOffice Community
Build ID: 47c428537154cd94b1d9a7547bde21ce711abd0d
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded

[Bug found by office-interoperability-tools]

Comment 1 Xisco Faulí 2022-07-19 11:56:51 UTC

Regression introduced by:

author	Justin Luth <justin_luth@sil.org>	2022-01-10 20:42:17 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	2022-02-01 13:31:33 +0100
commit 18cc1240565e697859dd7d17058f91d5e01df929 (patch)
tree d0e60e39cdbbc751becc52f88dc0f838f3bdd90d
parent 8e4624b9b9fa1322592b73fe0dd6cb03be6fd57f (diff)
tdf#141652 partial revert "Reset ShapeProperty priority...

Bisected with: bibisect-linux64-7.4

Adding Cc: to Justin Luth

Comment 2 Justin L 2022-07-19 12:25:10 UTC Comment hidden (obsolete)

I'm going to throw this one back to Gulsah/Miklos, since I know nothing about images.

Based on the previous bugs, any changes should be thoroughly testing in MS Word, and also should be compared to what LO 7.1 did - before the regression chain.

Comment 3 Xisco Faulí 2022-07-19 12:28:31 UTC

(In reply to Justin L from comment #2)
> I'm going to throw this one back to Gulsah/Miklos, since I know nothing
> about images.
> 
> Based on the previous bugs, any changes should be thoroughly testing in MS
> Word, and also should be compared to what LO 7.1 did - before the regression
> chain.

The behaviour seems to be correct in

Version: 6.3.0.0.alpha1+
Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: gtk3; 
Locale: es-ES (es_ES.UTF-8); UI-Language: en-US
Calc: threaded

Comment 4 Justin L 2022-07-19 13:19:11 UTC

Created attachment 181333 [details]
150061_71.jpg: LO 7.2 before commit b90a67838e189f3aee6a50724c78c0a50d416970

Comment 5 Xisco Faulí 2022-07-19 13:43:37 UTC

Regression introduced by:

author	Gülşah Köse <gulsah.kose@collabora.com>	2021-01-20 00:52:56 +0300
committer	Miklos Vajna <vmiklos@collabora.com>	2021-01-21 10:52:46 +0100
commit 2c96bd26ec488d865370fe9d394e7c4e228e05ab (patch)
tree 909bb4d78fe55fbaae205e7a3c3d44832dc61d36
parent e2b3b0b36558c719795644bdfa2853db5a8d6db7 (diff)
tdf#134210 Import support for custom stretch values.

Bisected with: bibisect-linux64-7.2

Adding Cc: to Gülşah Köse

Comment 6 Justin L 2022-07-22 18:15:48 UTC

Please revert my patch if Gulsah does not take ownership of this within a week.

Comment 7 Justin L 2022-07-28 22:12:37 UTC

Reverted in Master. Pending 7.4 revert in gerrit.