| Summary: | Missing row of pixels in tiled rendered text after pressing Enter in document | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Aron Budea <aron.budea> |
| Component: | Writer | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, vmiklos |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.4.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.5.0 target:7.4.0.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: |
Sample ODT
Screenshot (buggy) Screenshot (as the numbers should look like) Simpler test document. |
||
|
Description
Aron Budea
2022-07-26 07:09:01 UTC
Created attachment 181412 [details]
Screenshot (buggy)
Created attachment 181413 [details]
Screenshot (as the numbers should look like)
https://cgit.freedesktop.org/libreoffice/core/commit/?id=496426503675c6da60c6f3cd78549c8a70a8c694 was a little similar to this, but doesn't seem to be the issue in this case seems to be actually rendered like this, i.e. not something we're cutting off https://gitlab.freedesktop.org/cairo/cairo/-/issues/390 is very similar sounding In CairoTextRender::DrawTextLayout(), if we hit the case that eHintStyle is CAIRO_HINT_STYLE_DEFAULT, then we'll transition to CAIRO_HINT_STYLE_SLIGHT, and the output is bad. If default is handled like none or slight, then we don't call cairo_font_options_set_hint_style(), and the output is good. I need to read more code to understand if this would be a correct fix or not, perhaps you know. :-) Created attachment 181418 [details]
Simpler test document.
With this, you don't need to do any interaction, you can just run 'bin/run gtktiledviewer --lo-path=$PWD/instdir/program /path/to/test.odt' and see the good/bad output immediately.
https://gerrit.libreoffice.org/c/core/+/137467 is a possible fix for this bug Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/59cfcd863b483a99491e6f8cd30016386bbff870 tdf#150145 text appears to have a row of pixels cropped out It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/d51b00f635e665c19cec078979210df9f79a3aa3 tdf#150145 text appears to have a row of pixels cropped out It will be available in 7.4.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |