Bug 150438

Summary:	DOCX import: drop cap quotation marks are too big
Product:	LibreOffice	Reporter:	NISZ LibreOffice Team <libreoffice>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	nemeth, telesto
Priority:	medium
Version:	7.5.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=150200
Whiteboard:	target:7.5.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	109316
Attachments:	Test file drop_cap_quotation_marks Screenshot the problem

Description NISZ LibreOffice Team 2022-08-16 12:54:34 UTC

Description:
Quotation mark sizes are relative to the capital letters in drop cap layout, but not in Writer. This is not only an interoperability, but likely a typography issue, too (see Note).

Steps to Reproduce:
Load the attached DOCX file.

Actual Results:
3-line height punctuation marks.

Expected Results:
Smaller punctuation marks (their size is relative to the 3-line height capital letters).


Reproducible: Always


User Profile Reset: No



Additional Info:
See also
Tdf#150200

From Chicago Manual style (cited in https://www.reddit.com/r/grammar/comments/ium133/can_i_start_a_paragraph_with_a_drop_cap_quotation/) “When the first word of a chapter or section opens with a large raised or dropped initial letter, and this letter belongs to the beginning of a run-in quotation, the opening quotation mark is often omitted. If the opening quotation mark is included, it should appear in the same size and with the same vertical alignment as the regular text.”

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: c1446da82b999349e1a09fed3420bd1c38d7b38c
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Comment 1 NISZ LibreOffice Team 2022-08-16 12:58:02 UTC

Created attachment 181804 [details]
Test file drop_cap_quotation_marks

Comment 2 NISZ LibreOffice Team 2022-08-16 12:58:31 UTC

Created attachment 181805 [details]
Screenshot the problem

Comment 3 Commit Notification 2022-08-17 16:08:03 UTC

László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a18a74d6762e56a20093ca51cfd12925697c2524

tdf#150200 tdf#150438 sw, DOCX: fix drop cap dash, quotation etc.

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 László Németh 2022-08-17 16:10:11 UTC

Commit message of the fix:

tdf#150200 tdf#150438 sw, DOCX: fix drop cap dash, quotation etc.

In drop cap layout, set smaller size for all glyphs positioned
over the baseline, e.g. dashes (dash, en-dash, em-dash, figure dash),
bullet, asterisks and quotation marks by extending the bounding box
of the glyph to the baseline, like MSO does.

Add "DropCapPunctuation", a new default compatibility option for this.
Only old ODT files loads the old layout (which was partially broken:
e.g. dashes were too long, often missing from the drop cap area or
the drop cap was disabled). New ODT and imported DOCX documents
use the new default layout for better typesetting and interoperability.

Comment 5 NISZ LibreOffice Team 2022-08-29 06:32:13 UTC

Varified in:
Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: b323f1fba2a7a409177f5296c6ba8b98c9e537ad
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL