| Summary: | FORMATTING: Templates in nested folders are not displayed, allow nested categories in the Template Manager | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Emanuele Gissi <emanuele.gissi> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | NEW --- | ||
| Severity: | enhancement | CC: | andreas.heinisch, buzea.bogdan, emanuele.gissi |
| Priority: | medium | ||
| Version: | 7.3.4.2 release | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 101435 | ||
|
Description
Emanuele Gissi
2022-08-19 10:46:29 UTC
Valid enhancement. Should we allow an infinte depth of folders or limit them to a certain depth? Well, I do not imagine using more than 3 or 4 levels. But, as it happens for nested directories, I neither see a reason to limit nesting. I tried to understand the logic behind the creation of the template list and it is quite overwhelming. I think that in SfxDocTplService_Impl::createFromContent no sub folders are included, and I have to check if there is a possibility to read the entire directories including their sub folders to create the correct list by adding a new entry in the ResultSetInclude enum. Proposed patch: https://gerrit.libreoffice.org/c/core/+/139593 However, after opening a folder, LO somehow destroys the entire folder hierarchy and the files cannot be read again. I will try to speak to some people at the LiboCon and try to solve this, but at the moment after countless debugging houers I can't really help here :( Good job! A first step in the right direction. Thank you! May I help in any way? Testing? Atm, I hope to get the enhancement complete, but I am in cheerful spirits 😊 Could not figure it out how the HierarchyManager rertrieves its names and where it calls the file system, for instance, with FindFileW on Windows. It never calls them, somehow magically it has all the names of the files without any subdirectory. Sometimes all the subdiretories show up ,sometimes not, and I have no idea how to resolve this issue. So no hope to solve this bug? Anyway, happy new year Unfortunately, I have no idea how to solve this issue. Lots of calls to subclasses and delegations, even some kind of cache that checks if all the folders AND subfolders are in place. Then it even gets stranger. SOMETIMES all the folders including subfolders work, sometimes they disappear event on the file system itself. Imho, this section needs a rework or someone with a deeper understanding of the code base that left untouched for 22 years according to github. |