| Summary: | High Contrast theme is broken with GTK3. | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | folsk0pratima |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | 79045_79045 |
| Priority: | medium | ||
| Version: | 7.3.5.2 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.5.0 target:7.4.3 target:7.3.7 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103182 | ||
| Attachments: | For p.5,6 of the comments. Contains one png screenshot and one webm video. | ||
|
Description
folsk0pratima
2022-08-26 11:56:00 UTC
Please attach here some screenshots with your problems Created attachment 182754 [details] For p.5,6 of the comments. Contains one png screenshot and one webm video. Before describing screenshots, just want to mention another thing I noticed. If I download AppImage, unpack it (I don't want to use AppImage) and use *that* libreoffice, then everything is just OK. Should I download deb file and the bug shows up. The AppImage version I am using now and which works is 'LibreOffice 7.3.1.3 a69ca51ded25f3eefd52d7bf9a5fad8c90b87951' Since you need more info, I'll describe all the steps. I'm reproducing it in real time as I type the comment. 1. Download the still version: Linux (64-bit) (deb). 2. #!/bin/bash tar xf LibreOffice_7.3.6_Linux_x86-64_deb.tar.gz cd LibreOffice_7.3.6.2_Linux_x86-64_deb find DEBS/ -type f | while read -r file; do ar x "$file" rm debian-binary control.tar.gz tar xf data.tar.xz rm data.tar.xz done cd opt/libreoffice7.3/program 3. Launch it: ./soffice; open empty Writer document. 4. First of all, I am unable to select any icon style. Sifr is being enforced on me. If I delete it manually, I become able to choose. 5. Then, as you can see in 'writer_bug_demonstration.png', no icons, broken charts and black selection. 6. Watch 'impress_bug_demonstration.webm' (14 seconds). No icons and very slow response when typing. That's all I noticed. Extensions: I only have TexMath and it doesn't affect. Clean profile yields the exact same results. Version: version of the libreoffice I just reproduced the bug in is 'LibreOffice 7.3.6.2 c28ca90fd6e1a19e189fc16c05f8f8924961e12e' [Automated Action] NeedInfo-To-Unconfirmed Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/28bd6ad2318208644c13d355e91977389053170f tdf#150622 sidebar icons empty in High Contrast mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-4": https://git.libreoffice.org/core/commit/3d8fd5c90b12d17cf6c3c51aada9321afdaa2e98 tdf#150622 sidebar icons empty in High Contrast mode It will be available in 7.4.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/617b902fed3cb65f66bafd6868befd08067e1feb tdf#150622 sidebar icons empty in High Contrast mode It will be available in 7.3.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Confirm fixed icons in https://dev-builds.libreoffice.org/daily/libreoffice-7-3/Linux-rpm_deb-x86_64@tb87-TDF/2022-10-10_06.32.55/ Other bugs are still there. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/950b2712e78e4c5015aff3762d78558be8a642bd tdf#150622 use a solid border instead of a hatch for high contrast It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/046bc5029681444cb5d707b33a8aa3cc67732c22 tdf#150622 allow use of selection color for frame in HighContrast mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2734d2e058182a34c576e558138d84358c69ca5a tdf#150622 use high contrast selection fg/bg colors for text selection It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. A large scatter-gun bug is hard to deem fixed, but with High Contrast and GTK: * sidebar icons are visible now * hatching replaced with solid border, which hopefully also addresses performance vs other themes * system highlight color used for textbox selection frames * system highlight fg/bg colors used for text selection So I'll call this fixed as the specific GTK aspects are resolved. Separate bugs for remaining issues is always possible. In general "High Contrast" isn't an aesthetic thing, as an accessibility setting we're apparently following (or trying to anyway) guidelines something like https://learn.microsoft.com/en-us/windows/win32/winauto/high-contrast-parameter and "Map all colors to a single pair of foreground and background colors" and "Images that would typically be drawn in multiple colors should be drawn using the foreground and background colors selected for text" which is why we have unfilled drawing shapes and so on which is presumably why the charts and other things are quirky. https://lists.freedesktop.org/archives/libreoffice/2022-October/089453.html |