Bug 150939

Summary:	Conflicting information in UI strings "First name" and "Last name"
Product:	LibreOffice	Reporter:	Tuomas Hietala <tuomas.hietala>
Component:	UI	Assignee:	Rafael Lima <rafael.palma.lima>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hossein, rafael.palma.lima
Priority:	medium
Version:	7.4.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=151061
Whiteboard:	target:7.5.0
Crash report or crash signature:		Regression By:

Description Tuomas Hietala 2022-09-13 21:13:22 UTC

Description:
LO UI string dYqg2 is "First name". However, the context string is "businessdatapage|company-atkobject" and the relevant extended tip says "Type the name of your company in this field."

LO UI string EFGLj is "Last name". However, the context string is "businessdatapage|company2-atkobject" and the relevant extended tip says "Company second line".

It looks like either the UI strings themselves or the context strings and extended tips are wrong.


Steps to Reproduce:
1. See https://translations.documentfoundation.org/translate/libo_ui-master/swmessages/en/?checksum=514642a4b7aa1973 (and the extended tip immediately below)
2. See https://translations.documentfoundation.org/translate/libo_ui-master/swmessages/en/?checksum=90a51ac9a8f5f024 (and the extended tip immediately below)


Actual Results:
There is conflicting information on what the strings are about (personal details or the name of a company).

Expected Results:
Only whatever information is correct remains.


Reproducible: Always


User Profile Reset: No



Additional Info:
n/a

Comment 1 Rafael Lima 2022-09-14 12:51:21 UTC

The corresponding feature can be accessed via File - New - Business Cards and then select the Business tab.

From the dialog itself and from the source code [1] the strings seem to be wrong.

"First Name" should be "Company"
"Last Name" should be "Company 2nd line"

BTW these incorrect strings are used for a11y purposes, that's why the string in the dialog is correct.

Comment 2 Rafael Lima 2022-09-14 12:57:37 UTC

BTW the link to the source code [1] is:

[1] https://opengrok.libreoffice.org/xref/core/sw/uiconfig/swriter/ui/businessdatapage.ui?r=f89b94c2&mo=5927&fi=126#118

Comment 3 Rafael Lima 2022-09-14 13:17:13 UTC

Proposed patch available for review in:

https://gerrit.libreoffice.org/c/core/+/139845

Notice that there are other inconsistencies besides the ones you pointed out.

Comment 4 Commit Notification 2022-10-16 19:11:55 UTC

Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/00c2ea6946db89cec824439b35dcaab17ae75330

tdf#150939 Fix conflicting strings in businessdatapage.ui

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.