| Summary: | Down arrows in Calc AutoFilter are not very visible using dark mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
| Component: | Calc | Assignee: | Rafael Lima <rafael.palma.lima> |
| Status: | VERIFIED FIXED | ||
| Severity: | enhancement | CC: | 79045_79045, vsfoote |
| Priority: | medium | ||
| Version: | 7.5.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:7.5.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103184, 103512, 143344, 150915 | ||
| Attachments: |
Screenshot of the AutoFilter in dark mode
Screenshot of the patched button |
||
1) Using the selected color scheme: then we could use the Text color for the button background and Application Color for the down-arrow +1, I think we build these selection arrows (i.e. not from an icon theme) so maybe? If possible the Text color/Application Color from theme would be functional. Agree, it should be improved Created attachment 183383 [details] Screenshot of the patched button In [1] we see that COL_BLACK is hardcoded as the line color regardless of anything. And for the button color the FaceColor is used (which depends on system settings). [1] https://opengrok.libreoffice.org/xref/core/sc/source/ui/cctrl/dpcontrol.cxx?r=ce76f924#176 So I prepared a patch that draws the button with a light gray line (COL_LIGHTGRAY) when the face color is dark. Otherwise, the current COL_BLACK is used. See the screenshot of the patched version. The proposed patch is here: https://gerrit.libreoffice.org/c/core/+/142150 (In reply to Rafael Lima from comment #3) > Created attachment 183383 [details] > Screenshot of the patched button > The proposed patch is here: > > https://gerrit.libreoffice.org/c/core/+/142150 It looks much better now. I like it! Rafael Lima committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/750393ef151fed5eceb9d482975f4819d449666e tdf#151702 Improve contrast of down arrow of AutoFilter in dark mode It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fix verified with: Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: ad085990b8073a122ac5222e5220f8f1d6826dcf CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded |
Created attachment 183202 [details] Screenshot of the AutoFilter in dark mode See attached screenshot for more details. When using the Application Colors scheme "LibreOffice Dark" and the system theme is a dark variant, it's very hard to see the down-arrow button of the Autofilter. Actually it's rendered exactly the same when the "LibreOffice" scheme is used (with white document background). I believe this should be adaptive. We can solve this with two approaches: 1) Using the selected color scheme: then we could use the Text color for the button background and Application Color for the down-arrow 2) Using system colors. For instance, ShadowColor for the for the background and WindowColor for the down-arrow.