| Summary: | Avoid packing icons repeatedly for every build | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Hossein <hossein> |
| Component: | LibreOffice | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | enhancement | CC: | cloph, michael.stahl, parisoplop, telesto, vmiklos |
| Priority: | medium | ||
| Version: | 7.5.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
|
Description
Hossein
2022-11-09 11:17:55 UTC
Marking as New as Miklos confirmed the issue on IRC. I just confirmed that this is the reason for the status quo. I'm not that sure if we want to change the status quo: not rebuilding all the time will mean each & every icon will have to be listed in a makefile (do we want that?) and also you'll need to explicitly handle deleted icons (so even if all input icons of a zip are up to date, we may still need to rebuild the zip as it contains deleted icons). Do we want all this complexity? Perhaps Michael S (CC'd) has an opinion on this. deleted icons aren't a big problem imho but also they can be handled easily by having the rule that creates the zip-file depend on the makefile. then it's just the question if icon designers would be overly annoyed by having to edit a makefile whenever they work on the icons, which maybe you'd have to ask them. Fixed by cloph. Thanks! commit 0ff4b4a08deace66567d6248af9e41fc7336a1c1 Author: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Date: Sat Dec 10 17:52:23 2022 +0100 don't rebuild icon-themes if nothing changed Change-Id: I99ab68852d1f6e915a4cd92a4be2d28209e546ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143934 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> ah, should have checked bugzilla before writing the commit message :-) |