Bug 152323

Summary:	[LOCALHELP] Remove name= attribute in <links>
Product:	LibreOffice	Reporter:	Olivier Hallot <olivier.hallot>
Component:	Documentation	Assignee:	Buovjaga <ilmari.lauhakangas>
Status:	VERIFIED FIXED
Severity:	normal	CC:	ilmari.lauhakangas, olivier.hallot, stephane.guillou
Priority:	medium
Version:	7.5.0.0 alpha0+
Hardware:	All
OS:	All
Whiteboard:	target:7.5.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	80430

Description Olivier Hallot 2022-11-30 18:09:24 UTC

From PVT discussions, the name= attribute in the <link> tag is not used for a11y as defined in [1]

This name= attribute is furthemore marked as #IMPLIED in the DTD, which also turns it optional and discardable.

However this affects >5000 strings in the Help and we don't want to retranslate for so little benefit, which is only the simplification of the current XML (XHP).

This is a task to create a script or weblate procedure to remove name= from every <link> in the Help, on the already translated <links>. 

It must be transparent to translators.

Comment 1 Olivier Hallot 2022-11-30 18:12:31 UTC

[1] https://wiki.documentfoundation.org/Documentation/Understanding,_Authoring_and_Editing_Openoffice.org_Help/3#link

Comment 2 Buovjaga 2022-12-01 11:14:19 UTC

Comment from Cloph:

ok, so then it is just about getting rid of all name attributes, which makes it a lot easier than only removing some. So same procedure as last time then: having a patch for the changes in help, along with a script to remove it from po files would be easiest for me, if noone writes the script to work on the po-files I can do it. Important part is that the removal of name attributes should be all the gerrit-change does and not intermixed with other changes.

Comment 3 Commit Notification 2022-12-07 17:39:59 UTC

Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/7e42394ecbf921ee53160b495aa12c1cba158604

tdf#152323 drop name attribute from <link> elements

Comment 4 Stéphane Guillou (stragu) 2022-12-15 07:44:17 UTC

Thanks Cloph, Ilmari and Olivier for the solution, patch and wiki fix.

Fix verified in the master help source pages.