| Summary: | Numeral to right of RTL style name in sidebar and dropdown style previews | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
| Component: | Writer | Assignee: | خالد حسني <khaled> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | khaled |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.5.0.0 alpha0+ | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=87535 | ||
| Whiteboard: | target:7.6.0 target:7.5.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | Khaled Hosny | |
| Bug Depends on: | |||
| Bug Blocks: | 43808, 107328 | ||
|
Description
Stéphane Guillou (stragu)
2022-12-10 22:59:10 UTC
(same thing for the styles dropdown preview, which can be seen after applying the style to some more text) > Style "بلا عنوان1" has the numeral on the right of "بلا عنوان",
> which does not match the style properties.
I think you meant that the style name is rendered in the LTR-direction, with the neutral character 1 placed to the right of the hard-RTL sequence, as opposed to the RTL-direction.
Also, what about elsewhere in the UI, e.g. in the organizer?
Will try to reproduce with a new build soon.
Apologies, in the Description, the commit is completely irrelevant, I probably copy-pasted wrong. Bibisected with 7.5 Linux repo, confirmed regression for the sidebar, as expected starting with: commit 0483fbd1d05d74c394d9274bdee77b3b2aebb495 author Khaled Hosny <khaled@aliftype.com> Sun Aug 21 01:49:57 2022 +0200 committer Caolán McNamara <caolanm@redhat.com> Mon Aug 22 15:44:36 2022 +0200 tree 53c6bf1b3feb33bd8504132be585a02a5cca2244 parent 044fc5c8b225732d57970d3bf0720c13a5a9e0a4 tdf#87535: Preview styles using CTL/CJK fonts in the sidebar I assume the same issue in the dropdown was introduced by companion commit: https://git.libreoffice.org/core/commit/044fc5c8b225732d57970d3bf0720c13a5a9e0a4 (In reply to Eyal Rozenberg from comment #2) > Also, what about elsewhere in the UI, e.g. in the organizer? Displayed properly in the organiser as it is not a preview. That's what I meant with the poorly worded "does not match the style properties". Note that this issue affects other existing font previews, like the one in Character dialog. (In reply to خالد حسني from comment #4) > Note that this issue affects other existing font previews, like the one in > Character dialog. Bug 152533 Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/bfecacb2487ba9470600e6f64056d9b1816ee96b tdf#152460: Improve script handling in style previews It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Verified fix in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 4e4a31ac7d920c71e26ca4acd18c11ec2bd015bb CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Khaled! Khaled Hosny committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/85aac9d9b14d5af9700b34237cc9b0c82044cdbc tdf#152460: Improve script handling in style previews It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |