| Summary: | Line Width tool in the sidebar does not respect dark mode | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Rafael Lima <rafael.palma.lima> |
| Component: | UI | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | caolan.mcnamara, rizmut, stephane.guillou, telesto, vsfoote |
| Priority: | medium | ||
| Version: | 6.2 all versions | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.5.0.0.beta2 target:7.6.0 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 143344 | ||
| Attachments: |
Screenhot showing the problem
clip of 7.6.0 master from Win10 in 'dark' theme |
||
|
Description
Rafael Lima
2022-12-19 14:03:00 UTC
Created attachment 184242 [details] clip of 7.6.0 master from Win10 in 'dark' theme OK on Windows 10 in dark theme mode Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 98f0dd5e15733ac7f1d929d06ab230b5f04121d5 CPU threads: 8; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win Locale: en-US (en_US); UI: en-US Calc: threaded Also seen in e.g. Writer. Already an issue in 6.2 (grey on dark grey): Version: 6.2.0.0.beta1 Build ID: d1b41307be3f8c19fe6f1938cf056e7ff1eb1d18 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Not just KF5, GTK also affected. From what I could find in the code, the entries in the toolbar are images defined in: https://opengrok.libreoffice.org/xref/core/svx/inc/bitmaps.hlst?r=26643b50#128 And they're used here: https://opengrok.libreoffice.org/xref/core/svx/source/sidebar/line/LinePropertyPanelBase.cxx?r=f1b7a69b#405 So apparently we need to create the dark variant of these images. @Rizal, can you please check if fixing this bug indeed requires new images (dark variant), as per comment #3 ? Maybe, but on Windows builds we get a clean toggle/reverse of the fg/bg colors for the panel in 'dark' theme vs 'light' theme. So would think the same color swap can be done without needing new bitmaps. (In reply to V Stuart Foote from comment #5) > Maybe, but on Windows builds we get a clean toggle/reverse of the fg/bg > colors for the panel in 'dark' theme vs 'light' theme. So would think the > same color swap can be done without needing new bitmaps. I think there might be something to easily swap the color of bitmaps, but I could not find this in the code. Do you have a code pointer for this? I do not, but IIUC Caolán was able to tweak it for the Windows instance. Maybe same can be done for other os/DE... We are indeed using icons there, and https://opengrok.libreoffice.org/xref/core/svx/inc/bitmaps.hlst?r=26643b50#128 are the ones used. it happens that the colibre_dark theme has them as icon-themes/colibre_dark/svx/res/symphony/width1.png so that's why the Windows case works and the other don't That said, for the "Line Style" widget right above this Line Width widget we render the lines at runtime instead of using icons, so if we reuse that we don't have to force the icon people to create dark variants of these fairly simple lines and wait for all that to happen https://gerrit.libreoffice.org/c/core/+/144651 Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/eeec4a68376d142ab8912a6911bff0081e92a0ed Resolves: tdf#152593 reuse Line Style preview code for Line Width preview It will be available in 7.5.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/701ec65fff1cc532f7ee7b8be3883c6a536e2c85 Resolves: tdf#152593 reuse Line Style preview code for Line Width preview It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Fix verified in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 18b39c8c9b35528c8fb172339126b613827d09aa CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks Caolán! |