Bug 152683

Summary: LO Draw ignoring Undo:Resize Grouped Object
Product: LibreOffice Reporter: xordevoreaux
Component: DrawAssignee: Not Assigned <libreoffice-bugs>
Status: VERIFIED FIXED    
Severity: normal CC: noelgrandin, stephane.guillou
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.5.0.0 beta1+   
Hardware: x86-64 (AMD64)   
OS: All   
Whiteboard: target:7.6.0 target:7.5.0.2
Crash report or crash signature: Regression By: Noel Grandin
Bug Depends on:    
Bug Blocks: 100371    

Description xordevoreaux 2022-12-26 09:02:16 UTC 
Description:
Grouped objects regardless of type, once re-sized, cannot have the resize undone.
Undo:Resize Grouped Object not working.

Only tested in Draw.

Steps to Reproduce:
1. Launch LO Draw
2. Create two shapes (polygons, basic shapes, doesn't matter)
3. Group them
4. Resize the grouped object
5. Attempt to undo.

Actual Results:
Regardless using the drop-down menu or hitting Control-Z, resizing undo fails.

Expected Results:
Item should snap back to its original size after a Resize:Group Undo.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 780d55199e54fafc3784691d5cf716c1bb92b0aa
CPU threads: 8; OS: Windows 10.0 Build 19045; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded
Comment 1 Stéphane Guillou (stragu) 2022-12-28 23:35:39 UTC 
Reproduced in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 29c2bba1f3ef216d226c97197185066880fc1ab5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 2 Stéphane Guillou (stragu) 2022-12-29 07:41:18 UTC 
Regression present in:

Version: 7.5.0.0.beta1 (X86_64) / LibreOffice Community
Build ID: 3aca23eec42e9d6fbe57071d7633ae1fc4bc5fcc
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

But not in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: de-DE (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2022-12-29 08:03:14 UTC 
Also in Impress.

Bibisected with linux-64-7.5 repo. First bad commit refers to:

gerrit.libreoffice.org / core / 4e24efb563cbe6fec4185b4f7ec3755b2fc05b6b
commit 4e24efb563cbe6fec4185b4f7ec3755b2fc05b6b
author	Noel Grandin <noelgrandin@gmail.com>	Tue Nov 01 18:38:10 2022 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	Tue Nov 01 19:53:23 2022 +0100
tree b939ef5a2b3e4f09df7841d0b21d4da9dba8549b
parent d2a6bcd6a9430cbd5522c1a0e367e422b679cfd3

tdf#54857 elide more dynamic_cast

add a helper, following the same style as the ones in sw/

Change-Id: I13c673bba5ff47df6beef9d90c200e5801030cf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142119
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

Noel, can you please have a look?
Comment 4 Commit Notification 2022-12-29 12:25:55 UTC 
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/62ed082ee026023d332b2b4bbbc8a7b49580fa2e

tdf#152683 LO Draw ignoring Undo:Resize Grouped Object

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2022-12-31 10:08:40 UTC 
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/1f4214d7c3328bb6eb62656219a8322dfeaeb913

tdf#152683 LO Draw ignoring Undo:Resize Grouped Object

It will be available in 7.5.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Stéphane Guillou (stragu) 2022-12-31 15:14:04 UTC 
Fix verified in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 12e8d57e791bb1befc0716d4d02af7d1d1ccb4ae
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Noel!