Bug 152688

Summary:	Crash in: SkiaSalGraphicsImpl::applyXor() when changing row height
Product:	LibreOffice	Reporter:	Colin <that.man.colin>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	major	CC:	howard.girdlestone, stephane.guillou
Priority:	high
Version:	7.3.0.0 alpha1+
Hardware:	All
OS:	Windows (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=144144
Whiteboard:	target:7.4.0
Crash report or crash signature:	["SkiaSalGraphicsImpl::applyXor()"]	Regression By:
Bug Depends on:
Bug Blocks:	129062
Attachments:	The .ods that "crashed" it

Description Colin 2022-12-26 16:36:49 UTC

Created attachment 184356 [details]
The .ods that "crashed" it

This bug was filed from the crash reporting server and is br-9c204b60-81d5-4182-aff6-b03d0dc53e6d.
=========================================
Sheet Attached
I had just rescaled the 7 graphic elements V_A_I_L_N_O_P - which are copied from
          https://www.sbsolver.com/f/Vailnop
to fit into a smaller space.
I was in the process of increasing row height for row 9 - which is the final line above the split screen - by selecting that row and dragging the lower boundary. The objective being to "fit" the autofilter buttons into the row height as they will appear "oversized" with some row height and zoom factor combinations.
Ir was a bit "Fiddly" as the "complex" VLOOKUP(S) on sheet [palindromes] tends to slow the sheet down under certain operations so it's difficult to assess progress until the "mouse row hold" has been released.
The split screen was active so I would be dragging both the row and the "split" indicator line

Comment 1 Stéphane Guillou (stragu) 2022-12-27 17:52:21 UTC

Couldn't reproduce with 7.4:

Version: 7.4.3.2 (x64) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

But could with 7.3:

Version: 7.3.0.0.alpha1 (x64) / LibreOffice Community
Build ID: a3c29ae3d906f4692090bd4e5dab29623c66014a
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

I just changed the height of row 9 by drag-and-drop until it crashed. I could not reproduce with Skia turned off (unticked "Use Skia for all rendering" in Options > LibreOffice > View).

Can you reproduce in 7.4.3, Colin?

Comment 2 Colin 2022-12-27 18:47:43 UTC

(In reply to Stéphane Guillou (stragu) from comment #1)
> Couldn't reproduce with 7.4:
> 
> 
> Can you reproduce in 7.4.3, Colin?

No - Believe me I tried, I even made a few changes to formulae in the Palindrome sheet in between attempts but still no crash.

I shall leave you to claim kudos for resetting the status😉

Version: 7.4.3.2 (x86) / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

Portable version

Comment 3 Stéphane Guillou (stragu) 2022-12-28 12:21:27 UTC

Thanks Colin.

Fixing core commit by Luboš Luňák identified using the win64-7.4 bibisect repo.

commit f7a628f8efe037c1fd7e594eb4b8fc6a44573384	[log]
author	Luboš Luňák <l.lunak@collabora.com>	Fri Nov 26 09:10:57 2021 +0100
committer	Luboš Luňák <l.lunak@collabora.com>	Mon Nov 29 21:49:10 2021 +0100
tree 020ab596637fbe98ee599966dfd5287a9a034d6b
parent 4a11c85baeb4998e12bc2ab45b0c23d7203bd5b0 [diff]

implement xor drawing directly using Skia (tdf#141090)

Change-Id: Id751d0ed4034852ce68697ecf56cc6dfac95307f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126051
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

Comment 4 Stéphane Guillou (stragu) 2022-12-28 12:22:24 UTC

*** Bug 151805 has been marked as a duplicate of this bug. ***

Comment 5 Colin 2022-12-28 12:26:13 UTC

(In reply to Stéphane Guillou (stragu) from comment #3)
> Thanks Colin.
> 
Stéphane, 2 days from report to fixed - you're a bit good at this🤗