Bug 153127

Summary:	"Book preview" should be separate from other page preview buttons in Print Preview toolbar
Product:	LibreOffice	Reporter:	Stéphane Guillou (stragu) <stephane.guillou>
Component:	Writer	Assignee:	Heiko Tietze <heiko.tietze>
Status:	VERIFIED FIXED
Severity:	enhancement	CC:	buzea.bogdan, dgp-mail, heiko.tietze, hossein, mentoring
Priority:	low	Keywords:	difficultyBeginner, easyHack, skillDesign, topicDesign
Version:	6.1.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=152976 https://bugs.documentfoundation.org/show_bug.cgi?id=153609
Whiteboard:	target:7.6.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	80838
Attachments:	Proposed order of icons, with a separator

Description Stéphane Guillou (stragu) 2023-01-20 18:03:11 UTC

Created attachment 184795 [details]
Proposed order of icons, with a separator

Steps:
1. Open Writer
2. File > Print Preview

Currently, the Print Preview toolbar shows by default the page preview buttons in this order:

Single Page Preview – Two Pages Preview – Book Preview – Multiple Pages Preview

Book Preview is different to the others: it is used to show the first page on the right, so it reads like a book. I can be turned on or off regardless of how many pages are shown.
The three others are used to decide how many pages are shown at once, and are exclusive to each other.

A better order would be:

Single Page Preview – Two Pages Preview – Multiple Pages Preview – Book Preview

To clarify the distinction even further, a separator could be used:

Single Page Preview – Two Pages Preview – Multiple Pages Preview | Book Preview

...(see attachment) but that might be too much, given that they do to some extent belong together.

Issue present at least since:

Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk2; 
Locale: en-AU (en_AU.UTF-8); Calc: group threaded

Still in:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 579d144290c1617fdb38d09b30900a6bbe390b8d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

CCing UX for opinion on best solution, and Hossein for because I suspect it can be an easyHack.

Comment 1 Dieter 2023-02-04 06:29:10 UTC

I support that idea. I must admit, that it's the first time I've recognized print preview toolbar. I would also recommend to remove view options in status bar in print preview (but I will comment this in bug 152976).

Comment 2 Heiko Tietze 2023-02-06 11:48:08 UTC

+1

Code pointer:
sw/uiconfig/*/toolbar/previewobjectbar.xml (should be self-explanatory)
There are 6 view variants (resp. folders) with this toolbar, plus one singlemode-printpreview.xml. To find all, use git grep ".uno:ShowBookview"

Comment 3 Commit Notification 2023-02-07 13:55:34 UTC

Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/74590b782dfef65c612bb1577cdcb0a5f29df82a

Resolves tdf#153127 - Separate book from other modes in print preview

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 BogdanB 2023-02-12 19:33:35 UTC

Thanks Heiko and Stephane, nice improvement.
It's much clear now.

Verified with
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9d44236a62bf59d120dda89924d0d1407b2bd52b
CPU threads: 16; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded