Bug 153167

Summary: ImageMap dialog has no title
Product: LibreOffice Reporter: Adolfo Jayme Barrientos <fitojb>
Component: UIAssignee: Adolfo Jayme Barrientos <fitojb>
Status: RESOLVED FIXED    
Severity: normal CC: m.weghorn, stephane.guillou
Priority: low    
Version: 6.3 all versions   
Hardware: All   
OS: All   
Whiteboard: target:7.6.0
Crash report or crash signature: Regression By:

Description Adolfo Jayme Barrientos 2023-01-23 17:19:26 UTC
As it says on the tin
Comment 1 Stéphane Guillou (stragu) 2023-01-23 17:39:25 UTC
Adolfo, can you please provide some more information, including version information and simple steps?
I know some of us would know were to go, but some contributors are new to the QA process and I imagine a report with so little detail will not encourage them to learn more.
Comment 2 Adolfo Jayme Barrientos 2023-01-23 18:25:28 UTC
STR:

• On Writer, open Tools > ImageMap.
• Look at the title bar of the dialog that appears.

This issue has been there for years, perhaps since the transition to the GtkBuilder format.

Posted a Gerrit patch already.
Comment 3 Adolfo Jayme Barrientos 2023-01-23 18:59:26 UTC
OK, this regressed in commit 8a35ae3e6c5c45aa1426cfd81472b309d02a1b48 by accident.
Comment 4 Commit Notification 2023-01-23 20:46:26 UTC
Adolfo Jayme Barrientos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/66291d467be4bf0e841814111d57d1af76117f8e

tdf#153167 ImageMap Editor dialog had no title

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2023-01-24 08:37:32 UTC
Christian Lohmaier committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a90ef17809071b808a8c703e7e47e045ddabcd4a

Revert "tdf#153167 ImageMap Editor dialog had no title"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Michael Weghorn 2023-03-15 10:41:00 UTC
(In reply to Commit Notification from comment #5)
> Christian Lohmaier committed a patch related to this issue.
> It has been pushed to "master":
> 
> https://git.libreoffice.org/core/commit/
> a90ef17809071b808a8c703e7e47e045ddabcd4a
> 
> Revert "tdf#153167 ImageMap Editor dialog had no title"
> 
> It will be available in 7.6.0.
> 
> The patch should be included in the daily builds available at
> https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
> information about daily builds can be found at:
> https://wiki.documentfoundation.org/Testing_Daily_Builds
> 
> Affected users are encouraged to test the fix and report feedback.

Updated change based on the commit in comment 4, but now adding the required "context" attribute as well:
https://gerrit.libreoffice.org/c/core/+/148914
Comment 7 Commit Notification 2023-03-15 20:54:23 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/1aeacf54bf6c961d89678e961c747ff76d867c5f

tdf#153167 Re-add ImageMap Editor dialog title again

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.