Bug 153290

Summary:	Object's text box is temporarily invisible after ungrouping
Product:	LibreOffice	Reporter:	Mike Kaganski <mikekaganski>
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bakos.attilakaroly, stephane.guillou, vmiklos
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.5.0.2 rc
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=153289
Whiteboard:	target:7.6.0
Crash report or crash signature:		Regression By:	Miklos Vajna
Bug Depends on:
Bug Blocks:	108741, 122886

Description Mike Kaganski 2023-01-31 12:24:41 UTC

In a text document:

1. Create a couple of drawing objects (e.g., circles);
2. Select one of them, and type a few characters (so that the text is added to the object);
3. Select both objects, and group them;
4. Enter group;
5. Select the object with the text, right-click it, and choose "Add Text Box";
6. Exit group, select the group, and ungroup it.

==> the text on the object gets hidden.

7. Change zoom

==> the text appears again.

This happens in master, and in Version: 7.5.0.2 (X86_64) / LibreOffice Community
Build ID: c0dd1bc3f1a385d110b88e26ece634da94921f58
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL threaded

This works OK in Version: 7.4.0.3 (x64) / LibreOffice Community
Build ID: f85e47c08ddd19c015c0114a68350214f7066f5a
CPU threads: 12; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL

Comment 1 Stéphane Guillou (stragu) 2023-01-31 13:27:00 UTC

Reproduced with:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ec4babad021218b75dfe8534985d7db525edde69
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Not reproduced with:

Version: 7.4.5.1 / LibreOffice Community
Build ID: 9c0871452b3918c1019dde9bfac75448afc4b57f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Bibisecting now.

Comment 2 Stéphane Guillou (stragu) 2023-01-31 20:27:42 UTC

... and when I said "now", I meant "when I realise I forgot about it"! :)

Bibisected on linux-64-7.5 repo to first bad commit 6dd229bbde37ebc0cc51e2bda939249f4267ea56 which points to core commit:

commit 914d246e0edcbdfa5969b7f3eea7c67e1a5b7522
author	Miklos Vajna <vmiklos@collabora.com>	Wed Sep 28 08:54:06 2022 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	Wed Sep 28 09:46:30 2022 +0200
tree d3df578b72b0af615bda06e69588fac49bd1599e
parent ada3cf7a8392c59932fc339357cda9c3dda5c33f
crashtesting: fix PDF export of fdo83057-2.docx
Change-Id: Ia03f0ec70cf67626660349accc63770fe2afef5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140688

Miklos, can you please have a look?

Comment 3 Miklos Vajna 2023-10-16 07:03:08 UTC

Attila: do you have any interest to fix this? If not, I would tend to just disable the "add text box" UI for shapes inside group shapes, since any kind of support for "shape+textbox in a group shape" is relatively new, so I rather consider this an implementation error in that feature than a regression. (Added to fix bug 143574, ~2 years ago.)

Comment 4 Miklos Vajna 2023-11-15 13:51:43 UTC

I see that in the meantime this got fixed on master. Bisecting with linux-64-7.6.git (reverse-bisecting) points out that it was fixed in core.git commit 826b20b049449c9c335ce00c781cdb52e4ee0512 (Fix wrong layout of textbox in header, 2023-03-21).