Bug 153725

Summary:	Export to PDF is set to selection if cursor being inside a comment at the time of opening the dialog
Product:	LibreOffice	Reporter:	Telesto <telesto>
Component:	Printing and PDF export	Assignee:	⁨خالد حسني⁩ <khaled>
Status:	RESOLVED FIXED
Severity:	normal	CC:	danielfaleirosilva, khaled, michael.stahl, stephane.guillou, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	6.3.1.2 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=54908 https://bugs.documentfoundation.org/show_bug.cgi?id=139164
Whiteboard:
Crash report or crash signature:		Regression By:	Daniel Silva
Bug Depends on:
Bug Blocks:	103378, 106179

Description Telesto 2023-02-19 08:35:15 UTC

Description:
Export to PDF is set to selection if cursor being inside a comment at the time of opening the dialog

Steps to Reproduce:
1. Open Writer
2. Type: foo
3. Insert comment
4. Type: bar
5. File -> Export -> Export as PDF
6. Notice export area being set to selection
7. Check export comment in margin
8. Hit export
9. Open the PDF -> empty page

Actual Results:
Export area is set to selection by default if in comment

Expected Results:
Don't change the export area to selection. In this case you want to enable export notes in margin. It's not an invitation to change other dialog settings


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d8ae6d1388f28c405c4de2dfe93dbfe2d8acd470
CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Raster; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

Comment 1 Stéphane Guillou (stragu) 2023-03-05 13:16:08 UTC

Regression in 6.3:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

Not reproducible in 6.2:

Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

Comment 2 Stéphane Guillou (stragu) 2023-03-05 13:42:58 UTC

Bibisected with linux-64-6.3 repo to first bad commit 4f32ea24abee7f129870581a30539824d9e53b09 which points to core commit:

commit 87d5c863109f7991e3f2f3a1eb970c00d5a27bd5
author	Daniel Silva <danielfaleirosilva@gmail.com>	Sat Dec 08 10:15:26 2018 -0200
committer	Xisco Faulí <xiscofauli@libreoffice.org>	Sat Aug 03 14:21:41 2019 +0200
tree b6cbeabb262aa0d957cdaa362fa41dd3838c5ad5
parent dd2b7919058fc0e23a7117d39110d3ecaaad1fb2
tdf#54908 Make selection active if there's a selection (Writer)
If the user make a selection in Writer and then opens print dialog or PDF
export dialog, Print Selection is the default option.
Change-Id: I46ba90cfeabafef1c05dd3e5008ecf55f177a146
Reviewed-on: https://gerrit.libreoffice.org/64804

Daniel hasn't been active for a while, copying Michael and Xisco as reviewers of commit in question.

Comment 3 Telesto 2023-03-05 18:30:12 UTC

I'm still in favor of reverting the commit. See discussion at bug 139164

Comment 4 Stéphane Guillou (stragu) 2023-07-05 14:15:30 UTC

*** Bug 152573 has been marked as a duplicate of this bug. ***

Comment 5 Stéphane Guillou (stragu) 2023-07-05 14:18:08 UTC

The toolbar's "Export directly as PDF" is not affected.

Still present in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d74344f6cae0cf1c12f08249c8f49be1374fb98f
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Comment 6 ⁨خالد حسني⁩ 2023-08-07 12:22:10 UTC

Fixed with with bug 139164 by reverting the change introduced for bug 54908.