Bug 153867

The Penumbra Windows theme overwrites MS defaults.

Use the UltraUXThemePatcher to remove the "Penumbra 10" os/DE theme, reverting to MS color theme style(s) and retest.

Otherwise, pretty clearly => NOB

(In reply to V Stuart Foote from comment #1)
> The Penumbra Windows theme overwrites MS defaults.
> 
> Use the UltraUXThemePatcher to remove the "Penumbra 10" os/DE theme,
> reverting to MS color theme style(s) and retest.
> 
> Otherwise, pretty clearly => NOB

So you're saying that LibreOffice should only work correctly with the MS defaults, otherwise => NOB? Sounds weird.

As I said, I understand that this custom theme is a dirty hack, and the correctness of everything in any combinations cannot be guaranteed, but still in LibreOffice 7.4 this issue didn't exist. So it would be really nice to avoid it in the new version as well.

We are obliged to handle color theme defaults from the os/DE, and we do that with a fg/bg toggle. Your "hacked" Penumbra 10 color theme is over writing MS default color theme values with custom values such that our automated detection of os/DE Light color or Dark color themes misapply color within the checkbox.

Not saying it is correct, just saying we are not obliged to fix it.  Same holds for the HighContrast modes (Win10 or the new slate for Win11) we parse the WDM delivered HC color theme to some reasonable values for LibreOffice UI use.  Where for example the "GreyEve" theme, also available from deviantart.com, will lock in LibreOffice UI HC handling.

At 7.5 we've implemented enhanced support for detection of os/DE color theme and will toggle broadly to Light or to Dark depending on detection for "System", or for an LO "Light" or "Dark" manual toggle of the color theme.

You can try to Tools -> Options -> View  "Appearance" and set the "System|Light|Dark' mode to see if it behaves. 

Probably not, but then it is not our problem--we now respond to the os/DE color personalization from "Choose your color" deriving fg/bg color from the "default app mode" "Light|Dark" selection. But beyond fg/bg we don't handle UWP XAML for App color theming. So working with os/DE defaults for Light or Dark is about as far as we can go for Windows builds absent *major refactoring* to support UWP XAML

@Caolán, am I correct with that assessment?

Are you sure LibreOffice 7.5 with this "enhanced support for detection of os/DE color" handling all os/DE colors correctly and applies the right fg/bg values for the checkboxes?
In LibreOffice 7.5, checkboxes are the only UI element that has this issue with Penumbra theme. All other UI elements look correct with this theme.
LibreOffice 7.4 handled the default os/DE colors too, and the checkboxes looked correct with Penumbra theme there (light checkmark, on a dark background, as you can see in my screenshots)
I do not see such issue with Penumbra theme in other software that respond to the os/DE colors.

Checkbox, please attach the screenshot to this bug report instead of linking to them. Thank you!

Created attachment 186013 [details]
LibreOffice 7.4 with custom dark theme enabled (checkboxes are visible)

Created attachment 186014 [details]
LibreOffice 7.4 with experimental features and custom dark theme enabled

Created attachment 186015 [details]
LibreOffice 7.5 with custom dark theme enabled

Created attachment 186016 [details]
LO 7512 light mode on Win10 in os/DE dark color theme

Created attachment 186017 [details]
LO 7512 system mode on Win10 os/DE dark color theme

Pretty clearly an issue with the hacked Windows theme in use.

LO handling of Light and System/Dark with os/DE defaults for App color theme.

=> NOB

We can't (nor shouldn't) do anything with residual off brand win32 UI theme hacks. Better to spend effort to implement full UWP support. Meanwhile LO System/Light/Dark Appearance is functional for an effective Dark mode delivery for default MS dark/light App color theming.