Bug 153987

Summary: Can't set per-language quotation marks in Tools | AutoCorrect
Product: LibreOffice Reporter: Eyal Rozenberg <eyalroz1>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: minor CC: all.online, dgp-mail, heiko.tietze, rb.henschel, rgb.mldc, sdc.blanco, will.friedman
Priority: medium Keywords: needsDevAdvice
Version: Inherited From OOo   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=153989
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103341, 119352    

Description Eyal Rozenberg 2023-03-05 20:13:19 UTC
Single and double quotation marks are different for different written languages. Consequently, these are supposed to have per-language settings in Tools - under the "localized settings".

However, if I go there, I see a grayed-out label and drop-down box at the top of the dialog: 

Replacements and exceptions for language [ Hebrew  V]

why is this grayed out? I believe it should not be.
Comment 1 Dieter 2023-03-21 20:43:03 UTC
Language selection is greyed out in the following tabs: Options | Localised Options | Word Completion.
You can change language selection in the following tabs: Replace | Exceptions. I couldn't find any information in LO help. I don't see a reason for this and so I would call it a bug. But let's ask design-team.
Comment 2 Heiko Tietze 2023-03-22 10:11:30 UTC
(In reply to Eyal Rozenberg from comment #0)
> why is this grayed out? I believe it should not be.

I understand this as localized options are applied in all situations. The first option, space before punctuation in French, is a localized option for French text - but set globally.

It's in fact a bit confusing for the double quotes as "Lorem" becomes „Lorem“ for German and “Lorem” for English although the autocorrect option is always the same (start quote = double low-9 quotation mark, U+201E).
Comment 3 Dieter 2023-03-23 19:44:26 UTC
(In reply to Dieter from comment #1)
> Language selection is greyed out in the following tabs: Options | Localised
> Options | Word Completion.
> You can change language selection in the following tabs: Replace |
> Exceptions. I couldn't find any information in LO help. I don't see a reason
> for this and so I would call it a bug. But let's ask design-team.

If language setting is only relevant for Replace and Exceptions tab it should be removed in other tabs.
Comment 4 Regina Henschel 2023-03-23 22:07:40 UTC
Custom quotation marks are stored without language information in registrymodifications.xcu. And if you add language information there, it is not recognized.

We had the discussion already in bug 31609 and bug 70443.

I agree, it should be possible to set the quotation marks specific for a language. Especially, it should be possible e.g. to set angled quotation marks for German and keep the default replacement for other languages.

I think it is a valid enhancement request.
Comment 5 Heiko Tietze 2023-03-24 10:39:12 UTC
Bug 31609 is resolved worksforme, obviously we have it properly defined in the registry. Why do you need to overwrite it? 

And I wonder what the options "Single/Double Quotes" are good for.
Comment 6 Eyal Rozenberg 2023-03-24 13:01:51 UTC
(In reply to Heiko Tietze from comment #5)
> Bug 31609 is resolved worksforme, obviously we have it properly defined in
> the registry. Why do you need to overwrite it? 

1. It's not about me - overriding is supported, so it had been decided people need the override.

2. In Hebrew, there isn't a strong consensus on the default, and, in fact, some believe that the most common choice of opening and closing quotes is actually broken and needs to be (and can be) corrected.
Comment 7 Mike Kaganski 2023-04-20 13:04:01 UTC
Definitely a valid request.

Currently, this is *either* "use built-in defaults per language for substitution for all languages", *or* "use the defined characters irrespective of current language". Having an ability to use "use built-in defaults for all languages, except for this (having manually defined substitution A) and that (having manually defined substitution B)" is a valid idea.

(In reply to Heiko Tietze from comment #5)
> I wonder what the options "Single/Double Quotes" are good for.

Please note that https://en.wikipedia.org/wiki/Quotation_mark talks about both single and double quotation marks. The need to use a proper character for this punctuation is obvious from the very fact of its existence. Note that in other languages, it could be useful to have other two, or even *three*, different pairs of symbols (useful in nesting, or otherwise different semantically).
Comment 8 Stéphane Guillou (stragu) 2023-07-11 15:20:32 UTC
*** Bug 156021 has been marked as a duplicate of this bug. ***
Comment 9 Stéphane Guillou (stragu) 2023-07-11 18:00:43 UTC
*** Bug 156220 has been marked as a duplicate of this bug. ***
Comment 10 Stéphane Guillou (stragu) 2023-07-11 22:01:20 UTC
same in OOo 3.3, so inherited.