| Summary: | XML Form Document: Choosing Instance after first clicking on Bindings leads to Crash of LO | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Robert Großkopf <robert> |
| Component: | LibreOffice | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | critical | CC: | caolan.mcnamara, serval2412, stephane.guillou |
| Priority: | medium | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 7.1.0.0.alpha1+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=154307 https://bugs.documentfoundation.org/show_bug.cgi?id=147983 https://bugs.documentfoundation.org/show_bug.cgi?id=154503 https://bugs.documentfoundation.org/show_bug.cgi?id=154535 |
||
| Whiteboard: | target:7.6.0 target:7.5.3 | ||
| Crash report or crash signature: | ["SalInstanceTreeView::get_id(weld::TreeIter const&) const [clone .constprop.6917]","libgtk-3.so.0","SalInstanceTreeView::get_id(weld::TreeIter const &)"] | Regression By: | Caolán McNamara |
| Bug Depends on: | |||
| Bug Blocks: | 107742 | ||
| Attachments: |
gdb backtrace with LO 7.6
bt with debug symbols + console logs |
||
|
Description
Robert Großkopf
2023-03-22 10:02:46 UTC
Reproduced with both gtk3 and kf5 VCLs: Version: 7.5.1.2 (X86_64) / LibreOffice Community Build ID: fcbaee479e84c6cd81291587d2ee68cba099e129 CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Crash report kf5: https://crashreport.libreoffice.org/stats/crash_details/bf0741bc-0c64-4cd6-b5a2-a0462dd902de Crash report gtk: https://crashreport.libreoffice.org/stats/crash_details/38fb9bf5-810e-4cfb-9755-5ac54f8cd98a Also on Windows 10 with a recent master build: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: b5c3a7502f7ff6ccf0f829c1f3a2ba50b8584c41 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: en-IN (en_GB); UI: en-GB Calc: threaded Crash report on Windows 10 with LO 7.5.1.2: https://crashreport.libreoffice.org/stats/crash_details/6e02ad19-1717-4993-8fa9-2f2ffdaceb99 Same signature as unconfirmed bug 147983. Bibisected with linux-64-7.1 repo to first bad commit 8061e52b512c0e8f6ae6302b0ec39fc3386bd4a2 which points to core commit: commit 3c5e074a8fe5e0a18d326d37bc54a5ec0f077e4e author Caolán McNamara <caolanm@redhat.com> Fri Jun 19 12:37:05 2020 +0100 committer Caolán McNamara <caolanm@redhat.com> Tue Jun 23 10:21:08 2020 +0200 weld DataNavigator Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96750 Caolán, can you please have a look? Created attachment 186145 [details]
gdb backtrace with LO 7.6
Created attachment 186151 [details]
bt with debug symbols + console logs
On pc Debian x86-64 with master sources updated today, I could reproduce this.
I attached bt + console logs.
There seems to be a timer launched which triggers a clear and refill of the treeview which can take place while the right click context menu is running Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0cdd0a6603626d7da9c331771c77b8a719f0592a Resolves: tdf#154322 if entries are disabled while menu is active, update it It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b2beab144096c1f4f33ce0d9cacedbb80cc83594 tdf#154322 select the first entry of the current page by default It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. disable the menu entries if it is open, matching the toolbox entries getting disabled. which solves the crash, and preselect the first entry so the oddity doesn't tend to happen out of the box. Done in trunk, backport to 7.5 in gerrit Thanks Caolán, couldn't crash it in: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cae0daff1dd8bd60208892c792948c0cd2b0eeec CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Robert, would be great if you could also check that it all behaves as expected, as I'm not a seasoned user of the data navigator. Thank you! Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/830c69ac5ed9018d11d25bfb70a534d1a4b55c3d Resolves: tdf#154322 if entries are disabled while menu is active, update it It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Tested with Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e0daa98a802cc1f84ceb0f306f5d15fecabd62c1 CPU threads: 6; OS: Linux 5.3; UI render: default; VCL: kf5 (cairo+xcb) Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded Won't crash any more but: → creates the useless binding for instanceDate (Binding 1:) directly, without clicking on instanceData, which leads to the crash. → won't create any binding from added elements when clicking on added elements (This will work with older versions …) (In reply to Robert Großkopf from comment #12) > → won't create any binding from added elements when clicking on added > elements > (This will work with older versions …) Have to save and reopen the document → new bindings have been created without refreshing the tab "Binding". Seen if I try to add the bindings manually it will won't set the next number but counts all the elements I have created. > Won't crash any more but:
> → creates the useless binding for instanceDate (Binding 1:) directly,
> without clicking on instanceData, which leads to the crash.
> → won't create any binding from added elements when clicking on added
> elements
> (This will work with older versions …)
Might have to file another bug, I'm not sure what you're describing, (might have to simplify it for me, I don't use XML forms), is this a new problem from this attempt at a fix, or not rectified here and that was the hope?
(In reply to Caolán McNamara from comment #14) > > Won't crash any more but: > > → won't create any binding from added elements when clicking on added > > elements > > (This will work with older versions …) > > Might have to file another bug, I'm not sure what you're describing, (might > have to simplify it for me, I don't use XML forms), is this a new problem > from this attempt at a fix, or not rectified here and that was the hope? It is new with this fix. Open File → New → XML Form Document Right click on instanceDate → Add Element. Only press OK. Element had been added as NewElement. One mouse click on this NewElement. Change to "Bindings". Before this bug has been fixed the new binding for "NewElement" appears. Now you could see no new binding there. Seems there is a refreshing problem. If I change back to "Instance 1", close the tree view there and reopen it again, click on the filed and change to "Bindings" the new binding appears. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-5": https://git.libreoffice.org/core/commit/cf48e0236e0f1f5d2479573d73ec0f5325164406 tdf#154322 select the first entry of the current page by default It will be available in 7.5.3. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. with bug 154535 (hopefully) fixed is the issue of comment #12 satisfactory now? |