Bug 154549

Summary: Hebrew Nikkud marks mis-positioned on Arabic letters
Product: LibreOffice Reporter: ⁨خالد حسني⁩ <khaled>
Component: graphics stackAssignee: ⁨خالد حسني⁩ <khaled>
Status: RESOLVED FIXED    
Severity: normal CC: eyalroz1
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=139863
https://bugs.documentfoundation.org/show_bug.cgi?id=155514
Whiteboard: target:7.6.0 target:7.5.3
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 102985, 112810, 112812    
Attachments: Test document
Current rendering
Correct rendering in Firefox

Description ⁨خالد حسني⁩ 2023-04-01 21:30:37 UTC
Created attachment 186399 [details]
Test document

Some historical Arabic texts use Hebrew marks, but doing so in LibreOffice results in mispositioning of the marks.
Comment 1 ⁨خالد حسني⁩ 2023-04-01 21:33:34 UTC
Created attachment 186400 [details]
Current rendering
Comment 2 ⁨خالد حسني⁩ 2023-04-01 21:34:52 UTC
Created attachment 186401 [details]
Correct rendering in Firefox
Comment 3 ⁨خالد حسني⁩ 2023-04-01 21:39:13 UTC
Example of such historical texts https://www.lib.cam.ac.uk/genizah-fragments/posts/throwback-thursday-uncovering-karaites
Comment 4 Eyal Rozenberg 2023-04-01 22:49:17 UTC
Wow, I didn't realize the Qaraaites used Hebrew Nikkud on Arabic letters!

Reminds me a bit of how Maimonides wrote "Arabized" Hebrew - in Hebrew script, but using a lot of noun and verbs borrowed from Arabic rather than biblical Hebrew.
Comment 5 Commit Notification 2023-04-01 23:52:38 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/96aad0d0497c8486f8affc8fed79e63a060c9a59

tdf#154549: Make combining marks inherit the script of their base

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2023-04-02 20:43:22 UTC
Khaled Hosny committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/68c9de338fffcd564da990b88fe7119880339df7

tdf#154549: Make combining marks inherit the script of their base

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2023-04-05 18:44:40 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8c3e219a831719ebb40dd2af8a26b0a24ad7aba1

tdf#154549: vcl_pdfexport: Add unittest

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.