Bug 154731

Summary:	Enhancement: Simplify Zoom & View Layout dialog by eliminating unusable choices
Product:	LibreOffice	Reporter:	Don Matschull <dmatschull>
Component:	Draw	Assignee:	Baole Fang <baole.fang>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	heiko.tietze, mentoring, vsfoote
Priority:	medium	Keywords:	difficultyBeginner, easyHack, skillCpp, topicUI
Version:	7.4.6.2 release
Hardware:	All
OS:	All
Whiteboard:	target:7.6.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107923

Description Don Matschull 2023-04-09 16:29:35 UTC

The right side of the Zoom & View Layout dialog has an area titled "View Layout". This area was grayed out when I first saw it, so I searched to find out when and how it might be used.

I finally found a reference to the Zoom & View Layout in Chapter 3 of the Draw Guide that says of the View Layout area: "Used to set the view layout and is not available for drawings. View layout is normally used in text documents to see the effects of different layout settings."

Since this area is "not available for drawings", removing it from the dialog would eliminate confusion. The less confusing an application is, the easier it is to use.

Comment 1 V Stuart Foote 2023-04-09 16:55:24 UTC

The options are greyed out/non-selectable and that is sufficient as hiding it from the global Zoom & View layout would require either splitting the two functions, or unreasonable rework of the dialog.

IMHO => WF

Comment 2 Heiko Tietze 2023-04-11 09:24:41 UTC

Should be easyhackable to hide the controls instead of making it disabled.

The UI is cui/uiconfig/ui/zoomdialog.ui loaded in cui/source/dialogs/zoom.cxx and the function in question m_xViewFrame->set_sensitive(false);

Comment 3 Baole Fang 2023-04-17 19:08:43 UTC

Start working on this

Comment 4 Baole Fang 2023-04-20 17:36:03 UTC

I've submitted a patch here. Can anyone review it?

https://gerrit.libreoffice.org/c/core/+/150667

Comment 5 Commit Notification 2023-04-21 07:14:42 UTC

Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/56d2939e1928ae06fa74cb4b4be36cc0eaf3e702

tdf#154731: Hide Zoom & View Layout dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.