Bug 154732

Summary:	Zoom bar "Fit slide to current window" should be "page"
Product:	LibreOffice	Reporter:	Don Matschull <dmatschull>
Component:	Draw	Assignee:	Baole Fang <baole.fang>
Status:	RESOLVED FIXED
Severity:	normal	CC:	baole.fang, heiko.tietze, mentoring, vsfoote
Priority:	medium	Keywords:	difficultyMedium, easyHack, skillCpp, topicUI
Version:	7.4.6.2 release
Hardware:	All
OS:	Windows (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=114175 https://bugs.documentfoundation.org/show_bug.cgi?id=150477
Whiteboard:	target:7.6.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	107280

Description Don Matschull 2023-04-09 16:44:55 UTC

The white portion of the Workspace is referred to as a "page" in the Pages pane. The tooltip for the four-pointed arrow at the right of the Status Bar refers to this white portion of the Workspace as a "slide" when it states: "Fit slide to current window."

Using inconsistent terminology in this way can make LibreOffice draw appear confusing and hard to work with -- especially to those checking out LibreOffice Draw for the first time.

Comment 1 V Stuart Foote 2023-04-09 17:17:48 UTC

This is valid, but trivial. Draw and Impress share major components of the sd module. Similar to the "Slide # of #" labeling for both Draw and Impress UI.

Seems like an item that should have picked up for see also bug 114175, there are a few e.g. bug 150477

Comment 2 Heiko Tietze 2023-04-11 09:51:47 UTC

The string RID_SVXSTR_FIT_SLIDE defined in include/svx/strings.hrc accessed via svx/source/stbctrls/zoomctrl.cxx needs to be assigned depending on the module. It's assigned to the generic command .uno:ZoomPage in the statusbar, which is currently added only for Draw and Impress. 

Something for you, Baole?

Comment 3 Baole Fang 2023-04-11 12:47:12 UTC

Sure, I'll take this.

Comment 4 Baole Fang 2023-04-12 20:22:55 UTC

Hi Heiko, I'm wondering whether there is a way to get the document type in svx/source/stbctrls/zoomctrl.cxx.

Comment 5 Heiko Tietze 2023-04-13 06:31:50 UTC

(In reply to Baole Fang from comment #4)
> Hi Heiko, I'm wondering whether there is a way to get the document type in
> svx/source/stbctrls/zoomctrl.cxx.

The challenge never ends ;-). You better ask for help at the developer's IRC channel.

Comment 6 Commit Notification 2023-04-20 15:41:18 UTC

Baole Fang committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/91148ed5d5ef3428a39676bec672ccb5918ff19a

tdf#154732: Fix zoom bar in Draw

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.