Bug 154970

Summary:	Password protection lost when using Save As
Product:	LibreOffice	Reporter:	thewalnuts2
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	79045_79045, miguelangelrv, stephane.guillou
Priority:	medium
Version:	7.4.6.2 release
Hardware:	All
OS:	Windows (All)
Whiteboard:
Crash report or crash signature:		Regression By:

Description thewalnuts2 2023-04-23 15:09:57 UTC

Description:
When I use "Save As" on a password-protected document, the "Save As" dialog does not have the "Save with password" checkbox checked by default. This can result in a password protected document (Calc, I haven't tried others) being inadvertantly saved with no protection and is therefore a big security issue.

Steps to Reproduce:
1.Save a password protected document using "Save As"
2.
3.

Actual Results:
Doc was saved without password protection

Expected Results:
Doc to retain original protection


Reproducible: Always


User Profile Reset: No

Additional Info:
cannot be copied

Comment 1 Justin L 2023-04-23 22:01:53 UTC

This sounds like a duplicate of bug 142147. Please test with LO 7.6 (still in development).

Comment 2 m_a_riosv 2023-04-23 22:16:35 UTC

Thanks, @Justing, I couldn't find the original, please resolve as duplicate.
Works for me 
Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

Comment 3 thewalnuts2 2023-04-24 09:01:27 UTC

Using “Save a Copy” gives the same result as “Save as”, so saving a password protected document backup to a USB stick means you have an unprotected copy, which is a big security issue.

Comment 4 Stéphane Guillou (stragu) 2023-04-24 14:25:14 UTC

Tested with 7.5.3.1:
1. Create document, save password-protected.
2. Reopen: prompts for password
3. Save as -> does not save password-protected.

I agree with the expectation that a copy is saved password-protected (unsure if it should be the same password or be prompted for a new one, but behaviour in 7.5 is definitely not right).
"Save as", even though it offers a variety of formats, should at least _try_ to lose as little data as possible. Password protection is such data, and a particularly important kind of data.

In 7.6, I tested with the same file and both the Save As and Save Copy dialogs have the "Save with password" option ticked as a default, prompting for a new password.
So marking as duplicate like suggested by Justin.

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

*** This bug has been marked as a duplicate of bug 142147 ***