Bug 155001

Summary: Lost or malformed spellcheck underlines in rotated shapes
Product: LibreOffice Reporter: Stéphane Guillou (stragu) <stephane.guillou>
Component: DrawAssignee: ⁨خالد حسني⁩ <khaled>
Status: RESOLVED FIXED    
Severity: normal CC: khaled
Priority: medium Keywords: bibisected, bisected, regression
Version: 7.5.2.2 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=151968
Whiteboard: target:7.6.0.0 target:24.2.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 96000    
Attachments: example ODG
example ODG in LO 7.4.7 vs 7.5.3

Description Stéphane Guillou (stragu) 2023-04-25 08:26:26 UTC 
Misspelt text on rotated shapes results in malformed or missing wiggly red underline depending on case.

Steps:
1. Open attachment
2. See some malformed spellcheck underlines, some others entirely missing

Bibisected with linux-64-7.5 repo to first bad commit 77da9741e6691aea38fe019163453ce6a2215ffb which points to core commit 6327fdc149edab1eedabe5b0d4dde6bcf08a113e which is a cherrypick of:

commit 5899b27e71430e490c2d3a6b87ae52c10f383ba7	[log]
author	Khaled Hosny <khaled@aliftype.com>	Wed Feb 22 19:45:51 2023 +0200
committer	خالد حسني <khaled@aliftype.com>	Wed Feb 22 21:10:19 2023 +0000
tdf#151968: Fix vertical position of RTL spelling wavy line
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147488

Khaled, can you please have a look?

Repro in recent master too:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5cd9de202765e243e41416802f3e4486b8a96f16
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Stéphane Guillou (stragu) 2023-04-25 08:42:04 UTC 
Created attachment 186908 [details]
example ODG

Also in Impress.

Writer and Calc are not affected as they don't seem to ever show the underlines except while editing the text.
Comment 2 ⁨خالد حسني⁩ 2023-06-08 08:33:26 UTC 
Do you have a screenshot of what this file looked like before?
Comment 3 Stéphane Guillou (stragu) 2023-06-08 11:19:36 UTC 
Created attachment 187782 [details]
example ODG in LO 7.4.7 vs 7.5.3

Of course :)
Comment 4 ⁨خالد حسني⁩ 2023-06-10 15:17:41 UTC 
I reverted the 5899b27e71430e490c2d3a6b87ae52c10f383ba7 commit, so this should be fixed now.