| Summary: | Define a custom color does not work any longer | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Adalbert Hanßen <adalbert.hanssen> |
| Component: | Writer | Assignee: | Stephan Bergmann <sberg.fun> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | buzea.bogdan, sberg.fun, serval2412, Stefan_Lange_KA, stephane.guillou |
| Priority: | high | Keywords: | bisected, regression |
| Version: | 7.6.0.0 alpha1+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:7.6.0 | ||
| Crash report or crash signature: | Regression By: | Stephan Bergmann | |
| Bug Depends on: | |||
| Bug Blocks: | 87064 | ||
| Attachments: | Document with screenshot showing the bug | ||
|
Description
Adalbert Hanßen
2023-05-29 11:49:41 UTC
Created attachment 187579 [details]
Document with screenshot showing the bug
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Stephan: when trying to debug, I got this:
#0 0x00007fe577ea90a1 in __cxa_throw () at /lib/x86_64-linux-gnu/libstdc++.so.6
#1 0x00007fe5719bd598 in com::sun::star::cui::AsynchronousColorPicker::createWithParent(com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> const&, com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&) (the_context=uno::Reference to (cppu::(anonymous namespace)::ComponentContext *) 0x55d45bb55ec8, Parent=uno::Reference to (SalGtkXWindow *) 0x55d463012258)
at workdir/UnoApiHeadersTarget/offapi/normal/com/sun/star/cui/AsynchronousColorPicker.hpp:56
#2 0x00007fe5719bb945 in SvColorDialog::ExecuteAsync(weld::Window*, std::function<void (int)> const&) (this=0x55d46577c3a0, pParent=0x55d462cbf8c8, func=...) at svtools/source/dialogs/colrdlg.cxx:116
#3 0x00007fe572ef2670 in PaletteManager::PopupColorPicker(weld::Window*, rtl::OUString const&, Color const&)
(this=0x55d4651242e0, pParent=0x55d462cbf8c8, aCommand=".uno:Color", rInitialColor=rgba(255, 255, 255, 0)) at svx/source/tbxctrls/PaletteManager.cxx:411
#4 0x00007fe572f0bb09 in ColorWindow::OpenPickerClickHdl(weld::Button&) (this=0x55d465753170) at svx/source/tbxctrls/tbcontrl.cxx:2293
#5 0x00007fe572f0aafd in ColorWindow::LinkStubOpenPickerClickHdl(void*, weld::Button&) (instance=0x55d465753170, data=...) at svx/source/tbxctrls/tbcontrl.cxx:2283
Reverting 901360967dde5d3948d4a28d156ad526b0802ca1
"Combine com.sun.star.cui.[Asynchronous]ColorPicker implementation decls"
makes it work again.
Should we revert the patch or there's something else which must be fixed?
Stephan Bergmann committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2cda7933d1ed9e28153f6083e353df352851e235 tdf#155543 Get back com.sun.star.cui.AsynchronousColorPicker service impl It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. On pc Debian x86-64 with master sources updated today, I confirm I don't reproduce the bug anymore, thank you Stephan! (In reply to Julien Nabet from comment #4) > On pc Debian x86-64 with master sources updated today, I confirm I don't > reproduce the bug anymore, thank you Stephan! The bug does not appear any longer in Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 70fd835b4cf75e386ee115c705241a4059fb68a8 CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3 Locale: de-DE (de_DE.UTF-8); UI: en-US Calc: threaded Thank you for taking care of it. *** Bug 155660 has been marked as a duplicate of this bug. *** I can also confirm: The bug appears no longer with Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 182974354e4536af568dfb05a7400e48a2fe1032 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: de-DE (de_DE); UI: de-DE Calc: CL threaded |