| Summary: | Calc - change the location of the 'Sort by Color' option in the automatic filter menu | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | kabilo <minute.visitors> |
| Component: | Calc | Assignee: | Julien Nabet <serval2412> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | heiko.tietze, serval2412, xiscofauli |
| Priority: | medium | ||
| Version: | 7.6.0.0 alpha1+ | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | target:24.2.0 target:7.6.0.0.beta2 | ||
| Crash report or crash signature: | Regression By: | ||
| Attachments: | change the location of the Sort by Color option | ||
|
Description
kabilo
2023-06-08 05:13:01 UTC
Created attachment 187775 [details]
change the location of the Sort by Color option
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Heiko/Xisco: if ok, I can do the change with this straightforward patch:
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 50b85f1596c3..e68300c0b369 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -1077,9 +1077,9 @@ void ScGridWindow::LaunchAutoFilterMenu(SCCOL nCol, SCROW nRow)
mpAutoFilterPopup->addMenuItem(
ScResId(STR_MENU_SORT_DESC),
new AutoFilterAction(this, AutoFilterMode::SortDescending));
- mpAutoFilterPopup->addSeparator();
if (ScListSubMenuControl* pSubMenu = mpAutoFilterPopup->addSubMenuItem(ScResId(SCSTR_SORT_COLOR), true, true))
pSubMenu->setPopupStartAction(new AutoFilterColorPopupStartAction(this, pSubMenu, false));
+ mpAutoFilterPopup->addSeparator();
if (ScListSubMenuControl* pSubMenu = mpAutoFilterPopup->addSubMenuItem(ScResId(SCSTR_FILTER_COLOR), true, true))
pSubMenu->setPopupStartAction(new AutoFilterColorPopupStartAction(this, pSubMenu, true));
if (ScListSubMenuControl* pSubMenu = mpAutoFilterPopup->addSubMenuItem(ScResId(SCSTR_FILTER_CONDITION), true, false))
Yes, makes sense. (Color vs. Colour... I hope the British English comes from a localization and the American English is missing yet) Thank you Heiko for the quick feedback, I've submitted the patch on gerrit: https://gerrit.libreoffice.org/c/core/+/152734 Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7364b22c45f4f5592f0d9f9d89e66121b8053c4a tdf#155726: change the location of the 'Sort by Color' option It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Patch on gerrit for 7.6 branch here: https://gerrit.libreoffice.org/c/core/+/152751 Julien Nabet committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/083f3930ce8d74f908b29cfa751ad4805d3f21a8 tdf#155726: change the location of the 'Sort by Color' option It will be available in 7.6.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |