Bug 156268

Summary: CRASH: inserting row and undoing
Product: LibreOffice Reporter: Xisco Faulí <xiscofauli>
Component: CalcAssignee: Caolán McNamara <caolan.mcnamara>
Status: RESOLVED FIXED    
Severity: major CC: buzea.bogdan, dipamt1729, hossein, serval2412, xiscofauli
Priority: high Keywords: bibisected, bisected, haveBacktrace, regression
Version: 24.2.0.0 alpha0+   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=129847
Whiteboard: target:24.2.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 108364, 133092    
Attachments: gdb bt

Description Xisco Faulí 2023-07-13 08:17:22 UTC 
Steps to reproduce:
1. Open attachment 81889 [details] from bug 66506
2. Sheet - Insert Row - Row Above
3. Undo
4. Redo
5. Repeat step 3 and 4 a few times

-> Crash

Reproduced in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5a6b938d324798433298ec7320c813c82ace4590
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: x11
Locale: es-ES (es_ES.UTF-8); UI: en-US
Calc: threaded
Comment 1 Xisco Faulí 2023-07-13 08:18:19 UTC 
Regression introduced by:

author	anfanite396 <dipamt1729@gmail.com>	2023-04-20 20:33:56 +0530
committer	Hossein <hossein@libreoffice.org>	2023-07-06 11:18:38 +0200
commit 1d2380516ac9871743c5a5455f0734d02be8eade (patch)
tree 3c46c06ea2cc1770e559d836dd213a578d2499c5
parent 78dc5a38048d0fc8bcabc9e48520578d618176fa (diff)
tdf#129847 Show "more content" red arrow along with ### indication

Bisected with bibisect-linux64-24.2

Adding Cc: to anfanite396
Comment 2 Xisco Faulí 2023-07-13 08:19:42 UTC 
Also happening when inserting column
Comment 3 Xisco Faulí 2023-07-13 08:23:35 UTC 
Also happening with attachment 94167 [details] from bug 75059 when sheet 'TAB2' is deleting/undo a few times. Increasing importance
Comment 4 Julien Nabet 2023-07-19 15:04:08 UTC 
Created attachment 188470 [details]
gdb bt

On pc Debian x86-64 with master sources updated today + gen rendering, I got an assertion.
If I can help, here console logs + bt.
Comment 5 Hossein 2023-07-19 15:08:14 UTC 
I have provided this fix:

tdf#156268 Fix crash in Calc while adding more content red arrows
https://gerrit.libreoffice.org/c/core/+/154554
Comment 6 Julien Nabet 2023-07-19 15:14:46 UTC 
(In reply to Hossein from comment #5)
> I have provided this fix:
> 
> tdf#156268 Fix crash in Calc while adding more content red arrows
> https://gerrit.libreoffice.org/c/core/+/154554

Great! I've commented a bit on gerrit.
Comment 7 Hossein 2023-07-26 22:33:49 UTC 
The issue is fixed by the commit from Caolán:

commit     8bf6b877c6c4ee53611569a28114e7bbae000479
author     Caolán McNamara <caolan.mcnamara@collabora.com>	Mon Jul 24 21:40:23 2023 +0100
committer  Caolán McNamara <caolan.mcnamara@collabora.com>	Tue Jul 25 10:20:36 2023 +0200

crashtesting: a lot of crashes on exporting to ods

The problem is fixed now with the latest LO 24.2 dev master:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1f10a5b5a04a9d0cd5f456293e62e4f2c0fd7bb3
CPU threads: 12; OS: Linux 5.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: CL threaded
Comment 8 Commit Notification 2023-07-27 08:42:31 UTC 
Hossein committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f58dc86c9c8a257f620b009e243ab591a4a67ced

tdf#156268 Add UITest for Calc ### display crash

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.