| Summary: | Outline Folding Toggle not available for entire Headings outline | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | bathsheba <b> |
| Component: | Writer | Assignee: | Not Assigned <libreoffice-bugs> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | b, raykowj, stephane.guillou |
| Priority: | medium | ||
| Version: | 7.2.0.0.alpha0+ | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=138136 https://bugs.documentfoundation.org/show_bug.cgi?id=156978 |
||
| Whiteboard: | target:24.2.0 inReleaseNotes:24.2 | ||
| Crash report or crash signature: | Regression By: | ||
| Bug Depends on: | |||
| Bug Blocks: | 103030, 135310 | ||
| Attachments: | Patch that makes fold/unfold including sub levels menu items available in include sub levels mode | ||
|
Description
bathsheba
2023-07-14 02:15:17 UTC
EDIT: these options are missing only if the *Include sub levels* boxes are ticked, which are below the *Show outline-folding buttons* boxes. I think it's still a bug, Fold and Unfold All buttons should still be available from the Headings hamburger even if sublevels are included. Thanks for the report! It makes sense that "Fold/Unfold Including Sub Levels" are greyed out on single headings when "Include sublevels" is on, because they would duplicate the Toggle function unnecessarily. However, it is true that right-clicking on Headings > Outline Folding does not give the option to toggle the whole outline. I changed the summary to clarify what the issue is. Steps: 1. Enable "Experimental Features" 2. Enable "Options" > "LibreOffice Writer" > "View" > "Outline Folding" > "Show outline-folding buttons" 3. Also turn on "Include sublevels" 4. Create a Writer document with some headings and subheadings 5. In Navigator sidebar, context menu of Headings > Outline Folding Results: can't fold / unfold the whole outline. Tested with: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 24d0a62bd75b9a895c419aa165da648ab18f134d CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks!! My pain point with not being able to Unfold All is that folding changes the index: sub-levels under a folded level disappear from the index when it's updated. I'd prefer that folding not affect the index, but that might be too much to ask -- navigating to a folded header using the index would have to unfold it, which would probably be work -- but anyway I need a way to get back to a state where the index is complete. (In reply to bathsheba from comment #3) > My pain point with not being able to Unfold All is that folding changes the > index: sub-levels under a folded level disappear from the index when it's > updated. > > I'd prefer that folding not affect the index, but that might be too much to > ask -- navigating to a folded header using the index would have to unfold > it, which would probably be work [...] This would have to go into a separate report, but I'm unsure what its fate would be given that hidden sections are not even printed or exported to PDF (which makes the current behaviour consistent). Jim, what do you think about the issue described in this ticket? I think the best solution would be: making Toggle available in the top "Headings" context menu in the Navigator (instead of having it always greyed out like currently - which started when the sublevel option was introduced in 7.2 for bug 138136). (In reply to Stéphane Guillou (stragu) from comment #4) > This would have to go into a separate report, but I'm unsure what its fate > would be given that hidden sections are not even printed or exported to PDF > (which makes the current behaviour consistent). Fair enough. > Jim, what do you think about the issue described in this ticket? I think the > best solution would be: making Toggle available in the top "Headings" > context menu in the Navigator (instead of having it always greyed out like > currently - which started when the sublevel option was introduced in 7.2 for > bug 138136). <3 that is what I would like Created attachment 189059 [details] Patch that makes fold/unfold including sub levels menu items available in include sub levels mode Here is a patch that makes 'Fold/Unfold Including Sub Levels' available when outline folding is set to include sub levels. The patch also changes the behavior of not including outlines in the Navigator Headings content that are not visible in the document view to including them greyed out: https://gerrit.libreoffice.org/c/core/+/155881 I hope this is close to what is being asked for. Jim Raykowski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/f24f352da00b3e9a57e723c83008fc5854c38227 tdf#156282 Make 'Fold/Unfold Including Sub Levels' menu items It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Jim! I verified the fix with the gen VCL plugin: Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: e7496f41562b75ea9732ca48f9aa0c07b69e424f CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded (with gtk3, I get crashes. See bug 156978.) Thank you very much Jim! |