Bug 156299

Summary: Icon inconsistencies: menu Insert shape and Sidebar Shapes deck
Product: LibreOffice Reporter: Olivier Hallot <olivier.hallot>
Component: UIAssignee: Rizal Muttaqin <rizmut>
Status: RESOLVED FIXED    
Severity: normal CC: heiko.tietze, rafael.palma.lima, rizmut
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: target:24.2.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 107139, 117497, 120946, 120949, 125965, 131141    
Attachments: Screenshot describing the change
Icon used in menu Insert
Icon (diamond) used in sidebar

Description Olivier Hallot 2023-07-15 11:42:21 UTC 
The menu in the user interface of Writer, Calc, Impress and Draw shows lc_graphic (or sc_graphic).

The Shapes icon in the sidebar for Draw and Impress shows lc_basicshapes.diamond (or sc_basicshapes.diamond)

Both should be the same, preferably the sidebar Shape deck icon be lc_graphic.
Comment 1 Rafael Lima 2023-07-15 18:57:39 UTC 
Created attachment 188387 [details]
Screenshot describing the change

Just to be clear, I attached a screenshot of what I understood to be the proposed change (see attached image). Is this correct?

If so, the actual image used by the Insert - Shape menu depends on which icon theme is selected. For instance, in Breeze Dark the "ShapesMenu" command (menu entry) will redirect to the file cmd/32/basicshapes.pentagon.png. But Colibre Dark will point too insertdraw.png.

Maybe we can replicate this in the sidebar as well.
Comment 2 Heiko Tietze 2023-07-17 09:22:38 UTC 
Rizal, something for you?
Comment 3 Rizal Muttaqin 2023-07-17 11:54:30 UTC 
Please be specific for which icon theme you are talking about. A screenshot would be appreciated also.
Comment 4 Rizal Muttaqin 2023-07-17 11:55:22 UTC 
(In reply to Rafael Lima from comment #1)
> Created attachment 188387 [details]
> Screenshot describing the change
> 
I need a screenshot for original poster. :D
Comment 5 Olivier Hallot 2023-07-17 12:14:19 UTC 
Created attachment 188408 [details]
Icon used in menu Insert
Comment 6 Olivier Hallot 2023-07-17 12:14:53 UTC 
Created attachment 188409 [details]
Icon (diamond) used in sidebar
Comment 7 QA Administrators 2023-07-18 03:15:30 UTC Comment hidden (noise)
Comment 8 Commit Notification 2023-07-24 13:23:04 UTC 
Rizal Muttaqin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ed016c422f79777388c39d988c03c939730c0f2b

tdf#156299 Sync Insert Shape & sidebar Shape deck

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.