Bug 156337

Summary:	PDF export security tab is disabled and does not tell what is wrong
Product:	LibreOffice	Reporter:	Henrik Gebauer <code>
Component:	LibreOffice	Assignee:	Heiko Tietze <heiko.tietze>
Status:	RESOLVED FIXED
Severity:	enhancement	CC:	code, heiko.tietze, serval2412, xiscofauli
Priority:	medium
Version:	7.5.4.2 release
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
Whiteboard:	target:24.2.0
Crash report or crash signature:		Regression By:
Attachments:	screenshot proposed change (1) proposed change (2)

Description Henrik Gebauer 2023-07-17 16:59:06 UTC

Description:
I would like to export a Writer document as PDF and set a password protection for the PDF file. But the "security" page of the PDF export options dialog is disabled (grayed out). I can click on the tab but everything is disabled.

I guess that this is a wanted behaviour because the password protection cannot be set for some reason. But LibreOffice should at least display a message to tell me what is wrong so I can fix it.

Steps to Reproduce:
1. Use Writer or Calc to open a LibreOffice document or start with an empty document.
2. Go to File / Export as / PDF export
3. Go to the "Security" tab

Actual Results:
No password can be set, the whole page is disabled (grayed out).
No message is shown to tell me what is wrong.

Expected Results:
I should be able to set up a password protection or at least LibreOffice should show a message to tell me why I cannot do so.


Reproducible: Always


User Profile Reset: No

Additional Info:
It used to work in the past. I don't know what changed.

Comment 1 Julien Nabet 2023-07-18 12:35:49 UTC

Initially, there's no password defined so the quoted options are disabled since there's no restriction at all.

So you must first define a "permission password". To do this, click on "Set Passwords..." button, then you'll see that the quoted options are enable.

Comment 2 Henrik Gebauer 2023-07-19 22:39:14 UTC

Created attachment 188481 [details]
screenshot

Comment 3 Henrik Gebauer 2023-07-19 22:40:04 UTC

Thank you for the reply. But the "Set Passwords..." button is disabled as well (see screenshot).

Comment 4 Henrik Gebauer 2023-07-19 23:03:06 UTC

Created attachment 188482 [details]
proposed change (1)

Comment 5 Henrik Gebauer 2023-07-19 23:03:41 UTC

Created attachment 188483 [details]
proposed change (2)

or a combination of both suggestions

Comment 6 Henrik Gebauer 2023-07-19 23:05:25 UTC

Oh.. Now I see the message I was looking for is right in the screenshot I posted (-> no encryption because of PDF/A). But the message is grayed out so it never appeared to me it could contain useful information.

I will reduce the importance of this bug report to "enhancement".

I suggest to enhance the message to make it more visible. Two suggestions are in the modified screenshots.

Comment 7 Julien Nabet 2023-07-20 08:53:52 UTC

(In reply to Henrik Gebauer from comment #6)
> Oh.. Now I see the message I was looking for is right in the screenshot I
> posted (-> no encryption because of PDF/A). But the message is grayed out so
> it never appeared to me it could contain useful information.
> 
> I will reduce the importance of this bug report to "enhancement".
> 
> I suggest to enhance the message to make it more visible. Two suggestions
> are in the modified screenshots.

It seems reasonable to me.
Heiko/Xisco: any opinion here?

Comment 8 Heiko Tietze 2023-07-21 09:49:23 UTC

I think it's enough to keep the label sensitive. Patch at https://gerrit.libreoffice.org/c/core/+/154712

Comment 9 Commit Notification 2023-10-05 11:10:25 UTC

Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/07a06e40400f3713619cb456d62d4bb952e85436

Resolves tdf#156337 - Keep warning label enabled on PDF security tab

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.