Bug 156663

Summary: FILEOPEN PPTX: Skewed images shown with different aspect ratio and different clipping
Product: LibreOffice Reporter: Gerald Pfeifer <gerald>
Component: filters and storageAssignee: Not Assigned <libreoffice-bugs>
Status: RESOLVED DUPLICATE    
Severity: normal CC: aron.budea, jeremygharrison, kelemeng
Priority: medium Keywords: bibisected, bisected
Version: Inherited From OOo   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=134210
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 137753, 139902    
Attachments: Two sample slides (PPTX)
Visual comparison Impress (left) vs PowerPoint (right)

Description Gerald Pfeifer 2023-08-08 07:27:47 UTC 
Created attachment 188840 [details]
Two sample slides (PPTX)

This is the "slanted" sibling of bug #134210 ("FILEOPEN PPTX: Image 
shown with wider aspect ratio and different clipping - cropping not 
being applied).

 1. Open the sample document in both Impress and PowerPoint
 2. Observe how the skewed images on the two slides feature
    different cropping and aspect ratios between the two.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 47ca3f1f762352b488d58b3bf23d5776576f1cca
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US

all the way back to 6.4.
Comment 1 Gerald Pfeifer 2023-08-08 07:28:18 UTC 
Created attachment 188841 [details]
Visual comparison Impress (left) vs PowerPoint (right)
Comment 2 Aron Budea 2023-08-08 15:48:44 UTC 
Reproduced in LO 24.2.0.0.alpha0+ (46e672db8002e7aaac881bee65b5c50c4e14c666) / Ubuntu.

Before the following commit in 6.3 the image wasn't skewed, but it wasn't clipped, either.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=f4ba484183a1e7b9824f10580d633466c266828f
author		Tamas Bunth <tamas.bunth@collabora.co.uk>	2019-05-13 01:02:07 +0200
committer	Tamás Bunth <btomi96@gmail.com>	2019-05-13 18:14:26 +0200

"ooxml import: supprt cropping to shape"
Comment 3 Gerald Pfeifer 2023-08-17 22:22:38 UTC 
This has been fixed by
https://git.libreoffice.org/core/+/6c06c8a2be3d8cbbcb8ab1aaaeb04db95114dfcb%5E%21

Verified with Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 5fecd865303b3f0a2eeb0b9466d2bcf23cfce068
CPU threads: 8; OS: Linux 6.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Comment 4 Mike Kaganski 2023-08-18 06:55:37 UTC 
(In reply to Gerald Pfeifer from comment #3)
> This has been fixed by
> https://git.libreoffice.org/core/+/
> 6c06c8a2be3d8cbbcb8ab1aaaeb04db95114dfcb%5E%21

Aha, yes, you are right; and this is exactly the same issue - that the cropping wasn't applied from srcRect, because one of its members was negative.

Marking as duplicate. Thank you!

*** This bug has been marked as a duplicate of bug 153008 ***