Bug 156710

Summary:	GTK3: Cell format dialog not resizable and its height increases each time the border tab is used.
Product:	LibreOffice	Reporter:	Jean-Baptiste Faure <jbfaure>
Component:	Calc	Assignee:	Andreas Heinisch <andreas.heinisch>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andreas.heinisch, Darekbibula, QARON84, stephane.guillou
Priority:	medium	Keywords:	bibisected, regression
Version:	7.6.0.0 beta1+
Hardware:	x86-64 (AMD64)
OS:	Linux (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=149598
Whiteboard:	target:24.2.0 target:7.6.3
Crash report or crash signature:		Regression By:	Andreas Heinisch
Bug Depends on:
Bug Blocks:	108681

Description Jean-Baptiste Faure 2023-08-10 10:04:16 UTC

Description:
Each time I use the border tab of the cell format dialog box, its height increases. After several opening & closing the dialog box, its height becomes larger than the screen height and the buttons become not visible. 

Steps to Reproduce:
1.open a new empty spreadsheet
2.select a cell, right click and choose Format Cells... 
3.switch to Borders tab
4.change the borders using Style et Width dropdown lists
5.click the OK button
6.redo 2 to 5 several times

Actual Results:
Each time the Borders tab is used, its height increases.
The dialog box is not resizable, even if the cursor takes the double arrow form on its edge.

Expected Results:
Using the tab Borders of Format Cells dialog box does not change its size.
The dialog box is resizable.


Reproducible: Always


User Profile Reset: Yes

Additional Info:
To restaure the correct size of the Format Cells dialog box, I need to launch LibreOffice with generic VCL plugin. With the generic backend, this dialog box is resizable.

Version information (built at home under Ubuntu 22.04 with gcc 11 :

Version: 7.6.1.0.0+ (X86_64) / LibreOffice Community
Build ID: 6980f69c559861aba7279d5b90ae09f0347fa4d4
CPU threads: 8; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Ubuntu_22.04_x86-64
Calc: threaded

Comment 1 Jean-Baptiste Faure 2023-08-10 14:10:51 UTC

I recompiled LO with gcc 12 just in case. Then I saw that the dialog box is resizable the first time I open it. After using the Borders tab, the dialog box becomes not resizable.

Best regards. JBF

Comment 2 Jean-Baptiste Faure 2023-08-14 12:10:45 UTC

Of course, regression from version 7.5.

Best regards. JBF

Comment 3 Stéphane Guillou (stragu) 2023-09-09 07:06:16 UTC

Reproduced in:

Version: 7.6.1.1 (X86_64) / LibreOffice Community
Build ID: c7cda394c5de06de37d8109c310df89a4d4c3a98
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No repro:

Version: 7.5.6.2 (X86_64) / LibreOffice Community
Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Comment 4 Stéphane Guillou (stragu) 2023-09-15 10:04:11 UTC

Bibisected with linux-64-7.6 repo to first bad commit 4f7a5ad3b108a9e95347968eb0922a4561cf61f5 which is the range https://git.libreoffice.org/core/+log/cf4a1c42d6a90ec73ab1504d4bfaf3004bad33da..5e68d6cfade45f40b1ad46025a81afe4cb8dd337

Obvious commit is:

commit c1893df42567c260ca5fb069038d1a55616e7b7f
author	Andreas Heinisch 	Thu Jun 01 09:08:05 2023 +0200
committer	Andreas Heinisch 	Thu Jun 01 10:55:41 2023 +0200
tdf#149598 - Remember window state of the format cell dialog
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152474

Andreas, can you please have a look?

Comment 5 Andreas Heinisch 2023-10-06 12:23:54 UTC

No repro under Windows in:
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9b8ea553cf7f2fe5c913cb2b5e90d6d300b6be43
CPU threads: 16; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-AU (de_DE); UI: en-US
Calc: CL threaded

Can anyone test it under windows too plz?

Comment 6 Andreas Heinisch 2023-10-06 12:42:19 UTC

I can immagine that this happens because the tab pages will be added afterwards. Maybe this could fix it under Linux?

https://gerrit.libreoffice.org/c/core/+/157640

If anyone could try this fix. Atm, I have no Linux system available for the next two weeks.

Comment 7 Andreas Heinisch 2023-10-06 15:01:39 UTC

Tested it under Linux now. I coudl reproduce the problem and I have no idea why the problem arises under a tabbed dialog. Feel free to revert Bug 149598.

Comment 8 Andreas Heinisch 2023-10-07 06:50:38 UTC

Fixed by reverting Bug 149598.

Comment 9 Stéphane Guillou (stragu) 2023-11-07 10:47:42 UTC

*** Bug 158100 has been marked as a duplicate of this bug. ***

Comment 10 Stéphane Guillou (stragu) 2024-01-08 23:52:13 UTC

*** Bug 157728 has been marked as a duplicate of this bug. ***