Bug 157101

Summary:	New "Use background" option makes Area dialog too wide in Impress
Product:	LibreOffice	Reporter:	Stéphane Guillou (stragu) <stephane.guillou>
Component:	Impress	Assignee:	Gabor Kelemen (allotropia) <kelemeng>
Status:	VERIFIED FIXED
Severity:	normal	CC:	kelemeng, miguelangelrv, samuel.mehrbrodt
Priority:	medium	Keywords:	implementationError
Version:	7.4.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=128150
Whiteboard:	target:24.2.0 target:7.6.2
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	103223
Attachments:	The dialog in 24.2 bibisect and after the patch

Description Stéphane Guillou (stragu) 2023-09-05 13:25:04 UTC

Since background fill is supported in Impress, the Area dialog's Area tab is significantly wider, seemingly because all buttons use the same size based on the longest string – "Use Background".

We should find a way to reduce that width, so it is consistent with other components and so it still fits on small displays.

Steps to reproduce: 
1. Open Impress
2. Insert a shape
3. Context menu > Area > Area tab
4. Click through all options to see how unnecessarily wide the dialog is

Is there a good was to have None and Use Background grouped somehow, given that they are related in their effect and in that they don't offer any extra settings?

Tested in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 410632ac4b8a280e0993e665ffa9cfede8326b49
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Same in 7.4.

Comment 1 m_a_riosv 2023-09-05 22:43:11 UTC

Agree, bTW 'Use background' tab it's empty.
Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 410632ac4b8a280e0993e665ffa9cfede8326b49
CPU threads: 16; OS: Windows 10.0 Build 22621; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: CL threaded Jumbo

Comment 2 Gabor Kelemen (allotropia) 2023-09-10 18:57:18 UTC

Created attachment 189477 [details]
The dialog in 24.2 bibisect and after the patch

Proposed patch: https://gerrit.libreoffice.org/c/core/+/156804 

Not having this setting reduces width from more than half of a 1080p screen to less than half of it.

Tried to play a bit with other settings (spacing, expand, fill, alignment...) in Glade, but changing those had no similar effect.

Comment 3 Commit Notification 2023-09-12 07:46:57 UTC

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f9f5f80c758ca5f690827bc045b8ef66e16a46a2

tdf#157101 Make Area dialog narrower

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Stéphane Guillou (stragu) 2023-09-13 09:31:25 UTC

Fix verified in:

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 43df1237a091e2b0f4495d5a7e959f7beaab025d
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thank you Gabor!

Comment 5 Commit Notification 2023-09-13 21:48:26 UTC

Gabor Kelemen committed a patch related to this issue.
It has been pushed to "libreoffice-7-6":

https://git.libreoffice.org/core/commit/4f94245ef7ac0b49729c14454f02a28c70b6ac44

tdf#157101 Make Area dialog narrower

It will be available in 7.6.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.