Bug 157216

Summary: FILEOPEN PPTX: object specific glue points of preset shape "flowChartConnector" are not imported
Product: LibreOffice Reporter: Regina Henschel <rb.henschel>
Component: ImpressAssignee: Tibor Nagy <tibor.nagy.extern>
Status: RESOLVED FIXED    
Severity: normal CC: aron.budea, kelemeng, libreoffice, nemeth, tibor.nagy.extern
Priority: medium Keywords: bibisected, bisected, implementationError
Version: 7.4.0.3 release   
Hardware: All   
OS: All   
See Also: https://bugs.documentfoundation.org/show_bug.cgi?id=157543
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 159781    
Attachments: document with shape "flowChartConnector"
The minimized example file in PP 2016 and Impress
Missing glue points in 5-point-star

Description Regina Henschel 2023-09-12 21:02:22 UTC
Created attachment 189532 [details]
document with shape "flowChartConnector"

Open attached document. It contains the shape "flowChartConnector". That shape has 8 glue points. The drawing has connectors to each of them. The second slide has a screenshot how it looks in PowerPoint.

Error: The connectors use wrong target glue points.

In addition the escape directions are wrong, but that is bug 157215.

When you look at the GluePoints property with the Development Tools, you see that the object specific glue points do not exist, but only the four default glue points.
Comment 1 Gabor Kelemen (allotropia) 2023-09-13 08:44:07 UTC
Created attachment 189544 [details]
The minimized example file in PP 2016 and Impress

Confirming in

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: beaea2e992912b4747d790070b26371f557b1f57
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: threaded
Comment 2 Gabor Kelemen (allotropia) 2023-09-13 08:49:04 UTC
This was good in 7.3, seems to have started in 7.4 with:

https://git.libreoffice.org/core/+/cbf66ec3e60d07efb7c3cceed9b4f0fb4f0510c8

author	Tibor Nagy <nagy.tibor2@nisz.hu>	Thu Mar 10 08:42:12 2022 +0100
committer	László Németh <nemeth@numbertext.org>	Tue Mar 29 16:12:45 2022 +0200

tdf#89449 PPTX import: fix line connectors

Adding CC to: Tibor Nagy

It was not exactly the same after this as today, it was somewhat less broken.
Comment 3 Regina Henschel 2023-10-01 17:18:13 UTC
(In reply to Gabor Kelemen (allotropia) from comment #2)

> This was good in 7.3:...

In previous versions, the connectors were not imported as connector but as ordinary shape, see bug 89449.
Comment 4 Regina Henschel 2023-10-01 17:21:54 UTC
Created attachment 189934 [details]
Missing glue points in 5-point-star

And another example, where the missing glue points lead to totally wrong connectors. The file contains a screenshot in the lower part that shows how the drawing looks in PowerPoint.
Comment 5 Commit Notification 2024-06-29 20:49:58 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e6b974fd699dcef28a7c26a96c74f3b9a8df9cab

tdf#157216 PPTX: add "glue points" to flowchart shapes

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2024-07-01 13:49:54 UTC
Tibor Nagy committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/e6801d4e910b1da2635472f3b6d0b777af116554

tdf#157216 PPTX: add "glue points" to flowchart shapes

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.