Bug 157234

Summary:	Should "Consider wrapping styles when positioning objects" be ON as default?
Product:	LibreOffice	Reporter:	sdc.blanco
Component:	Writer	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	heiko.tietze, hossein, michael.stahl, vmiklos
Priority:	medium
Version:	24.2.0.0 alpha0+
Hardware:	All
OS:	All
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	113944, 157006

Description sdc.blanco 2023-09-14 10:14:09 UTC

1. Tools - Options - LibreOffice Writer - Compatibility
2. Select option "Consider wrapping styles when positioning objects"

Two issues here.  

1. According to help [1], it seems like it the the preferred option is to have this option ON (i.e., box is checked).

Afaict, the default for this option is OFF.  

Is the help wrong? or maybe the default should be changed?

2. If I understand the idea here, then it seems better to change the label for this option to "Use OpenOffice 1.1 wrapping style to position objects" 

I think this might require a change in the backend so that when it is selected (ON), then the "old 1.1" behavior is used.  

This proposed change would then make the label/function consistent with the other "Use OpenOffice 1.1 ..." options, and would not require a change in the default setting. 

[1] https://help.libreoffice.org/24.2/en-US/text/shared/optionen/01041000.html?DbPAR=WRITER

Comment 1 Heiko Tietze 2023-09-27 06:59:25 UTC

Miklos, please verify that switching on this option means the "iterative process" (old way) becomes "straightforward" (new and MSO compatible) (what a pointless documentation!).

Comment 2 Miklos Vajna 2023-09-27 07:46:33 UTC

This is the ConsiderTextWrapOnObjPos setting, http://www.openoffice.org/specs/writer/compatibility/obj-pos-without-wrapping.sxw has some details on it.

I can confirm that currently we disable this for new documents, disable this for old ODT docs and enable it for Word formats.

Unless Michael S can recall some reason for the current default for new documents, changing the default for new documents to "true" sounds reasonable to me, not objecting. This would be consistent with a number of similar compat flags (e.g. AddParaSpacingToTableCells) that are off for old ODT docs, but are enabled elsewhere.

Comment 3 Heiko Tietze 2023-10-04 12:29:17 UTC

(In reply to Miklos Vajna from comment #2)
> Unless Michael S can recall some reason...

Apparently not, let's do it. Easy hack, Hossein?

Comment 4 sdc.blanco 2023-10-06 10:32:06 UTC

(In reply to Heiko Tietze from comment #3)
> (In reply to Miklos Vajna from comment #2)
> > Unless Michael S can recall some reason...
> 
> Apparently not, let's do it. Easy hack, Hossein?
1. Setting it "on" should be easy:  change "false" to true" at: https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/Compatibility.xcs?r=645852b4#99

2. Even better would be:

1.  Leave the setting false.
2.  Change the backend so that "true" means that the "old" style is used.
3.  Change command label to: "Use OpenOffice.org 1.1 for object positioning"

Reason:  This would then make this command consistent (UI gold standard) in behavior and labeling with all the other "Use OpenOffice.org 1.1 ..." options in this dialog. 

See: https://help.libreoffice.org/24.2/en-US/text/shared/optionen/01041000.html

This "better" version might still be an easy hack.