Bug 157663

Summary: Writer: Tracked changes moved text: Accept/Reject only handle 1 side of it
Product: LibreOffice Reporter: Attila Szűcs <attila.szucs>
Component: WriterAssignee: Attila Szűcs <attila.szucs>
Status: ASSIGNED ---    
Severity: enhancement CC: buzea.bogdan
Priority: medium    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard: target:24.2.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 83946    
Attachments: sample file with some move tracked changes

Description Attila Szűcs 2023-10-09 02:52:19 UTC 
Description:
Moved text with tracked changes are displayed as 2 changes, an insert, and a delete side.
To accept or delete it, we need to accept/delete both sides. (And even to find their pairs can be a bit hard some times)
In Word it is enought to accept or reject 1 side, and it will handle the other side as well.

(Note: in many cases Writer not recognise text movements, it could be improved too)
Attached a sample file with some movement redlines.

Steps to Reproduce:
1. open the sample file
2. open manage changes sidebar
3. select a moved or pasted redline
4. reject or accept it.

Actual Results:
It will reject or accept only the selected part of if, the delete, or the insert part.
The other part will remain the same, we have to select that too and click on accept/ reject there too.

Expected Results:
It should accept / reject both part of a move change.. the insert, and the delete part, at once.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 0a90b90048313fb43f8c5d7461f58dafec276600
CPU threads: 6; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: CL threaded
Comment 1 Attila Szűcs 2023-10-09 02:53:38 UTC 
Created attachment 190091 [details]
sample file with some move tracked changes
Comment 2 Commit Notification 2023-10-29 18:31:12 UTC 
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e4fb4937b3f75ce3544f8de354ed92f7dd314511

tdf#157663 SW: Tracked change improve move

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2023-10-29 23:39:40 UTC 
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2c3f731992a294d4f35b41193af034fe9a6dd65c

tdf#157663 SW: reenable move recognition improvements

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2023-10-30 00:56:48 UTC 
Attila Szűcs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b40e469887d973e1eea242749a90c3c2370da3a5

tdf#157663 SW: fix redline continueing a move

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.