Bug 157840

Summary:	Unify lockdown behavior of Options dialog page Security
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	UI	Assignee:	Balázs Varga (allotropia) <balazs.varga991>
Status:	RESOLVED FIXED
Severity:	normal	CC:	stephane.guillou
Priority:	medium
Version:	Inherited From OOo
Hardware:	All
OS:	All
Whiteboard:	target:24.2.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	157698
Attachments:	Lock down extension for the Security page The Security page after installing the extension The Certificate Path dialog after installing the extension The TSA URL dialog after installing the extension Updated extension with new keys added in bug 157484

Description Gabor Kelemen (allotropia) 2023-10-20 08:32:16 UTC

Created attachment 190314 [details]
Lock down extension for the Security page

When the settings of the Options dialog page Security are locked down, several of the UI elements do not reflect this by becoming disabled and displaying a lock icon on their left.

1. Install the attached extension in the Tools - Extensions dialog
2. Restart LibreOffice
3. Go to Tools - Options - Security
-> the UI elements have no lock icon on their left, they are not disabled, changing their status and pressing OK usually crashes LibreOffice

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 9f44f9fad759dea644356b67b9cd0fab030e8b77
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: x11
Locale: hu-HU (hu_HU.UTF-8); UI: en-US
Calc: threaded

Comment 1 Gabor Kelemen (allotropia) 2023-10-20 08:32:50 UTC

Created attachment 190315 [details]
The Security page after installing the extension

Comment 2 Gabor Kelemen (allotropia) 2023-10-20 08:55:29 UTC

Created attachment 190318 [details]
The Certificate Path dialog after installing the extension

Comment 3 Gabor Kelemen (allotropia) 2023-10-20 08:56:02 UTC

Created attachment 190319 [details]
The TSA URL dialog after installing the extension

Comment 4 Stéphane Guillou (stragu) 2023-10-20 10:19:29 UTC

Confirmed.
E.g. Macro Security Level and "Security Options and Warnings" dialog are locked properly with the lock icon, but I can change the Certificate path and crash it.

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b83f069101f1e6d8aaac09a805f02bbc4c619e7a
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Comment 5 Gabor Kelemen (allotropia) 2023-10-20 12:54:58 UTC

Created attachment 190343 [details]
Updated extension with new keys added in bug 157484

Comment 6 Commit Notification 2023-10-26 07:22:15 UTC

Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6a8cae6995d22666c0a6fd2b42c171ef27ae30ac

tdf#157840 - UI: Part 6 - Unify lockdown behavior of Options dialog

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.