| Summary: | Basic code completion regression: overwrites dot; characters not visible while typing | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
| Component: | BASIC | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | normal | CC: | aron.budea, caolan.mcnamara, hossein, rafael.palma.lima |
| Priority: | medium | Keywords: | bibisected, bisected, regression |
| Version: | 7.0.0.3 release | ||
| Hardware: | All | ||
| OS: | Linux (All) | ||
| See Also: | https://bugs.documentfoundation.org/show_bug.cgi?id=92964 | ||
| Whiteboard: | target:24.2.0 target:7.6.5 | ||
| Crash report or crash signature: | Regression By: | Caolán McNamara | |
| Bug Depends on: | |||
| Bug Blocks: | 124891 | ||
|
Description
Stéphane Guillou (stragu)
2023-11-29 15:54:18 UTC
FTR this is repro with Version: 7.6.3.2 (X86_64) / LibreOffice Community Build ID: 60(Build:2) CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: kf5 (cairo+wayland) Locale: pt-BR (pt_BR.UTF-8); UI: en-US Ubuntu package version: 4:7.6.3~rc2-0ubuntu0.23.10.1~lo2 Calc: threaded Code pointer here: https://opengrok.libreoffice.org/xref/core/basctl/source/basicide/baside2b.cxx?r=bd6fb0cd#2702 TBH I do not understand the call to GetLastHighlightPortionTextSelection. If I simply comment out these two lines of code, the problem disappears: GetParentEditView()->SetSelection( aTextSelection ); GetParentEditView()->DeleteSelected(); Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/6aba19406767a54bb61eaffb2903c1b2902da9a8 Resolves: tdf#158441 we don't want to return early for all handled keys It will be available in 24.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/ea7c17960ddfe93249b17612662adc4694bd02b3 Resolves: tdf#158441 we don't want to return early for all handled keys It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thanks Caolan for the fix. It works now, however there's another issue... when I press Enter, I was expecting for the selected entry to be entered without jumping to the next line. (In reply to Rafael Lima from comment #5) > It works now, however there's another issue... when I press Enter, I was > expecting for the selected entry to be entered without jumping to the next > line. That was already the case before the regression, so I'd say a new report needs to be opened. Fix verified in: Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: 0ddd9f7e055a0c1ecb120de3e40c3fdb8373e9dc CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded Thanks! |