Bug 158570

Summary:	FILEOPEN XLSX Grid color not displayed anymore
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	heiko.tietze, raal, rb.henschel
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.6.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=152184
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	112752
Attachments:	Example file from Excel 2016 The example file in Excel2016 and Calc master Colored grid example from Calc 7.4

Description Gabor Kelemen (allotropia) 2023-12-06 20:37:24 UTC

Created attachment 191280 [details]
Example file from Excel 2016

Attached Excel-made document contains an orange grid color setting.
This used to work in Calc, but now the grid is default grey.

1. Open attached document
-> Grid is not orange.

Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 43967453e15e1d054972a7586cfef8f8e0866270
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Bibisected under windows-76 to:

https://git.libreoffice.org/core/+/5675937f7564fa5614f7be5aec0d7f20ba91d02c

author	Heiko Tietze <tietze.heiko@gmail.com>	Fri Mar 17 16:10:39 2023 +0100
committer	Heiko Tietze <heiko.tietze@documentfoundation.org>	Wed Mar 29 10:34:27 2023 +0000

Resolves tdf#152184 - Application color should follow system color

Comment 1 Gabor Kelemen (allotropia) 2023-12-06 20:37:56 UTC

Created attachment 191281 [details]
The example file in Excel2016 and Calc master

Comment 2 raal 2023-12-07 07:52:02 UTC

Confirm with Version: 24.2.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 55097433ed766a2ced6b87021a71c8a31cde9d99
CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Comment 3 Heiko Tietze 2023-12-07 09:10:59 UTC

Do we save the grid color in the document? Doubt this. IMO not supported.

(Not sure why exactly my patch prevents this, haven't touched a filter.)

Comment 4 Heiko Tietze 2023-12-07 09:17:38 UTC

(In reply to Heiko Tietze from comment #3)
> IMO not supported.

Saving a document with green gridlines and another with red does not bring back this color. Tested with 7.4. Excel apparently saves the grid color and we mistakenly applied it in the past (while keeping the color scheme Automatic; if the color is/was not Automatic is would have been applied over the orange in previous versions too).

My take: either we resolve this ticket as WF or remove the option from the filter.

Comment 5 Gabor Kelemen (allotropia) 2023-12-07 14:16:39 UTC

(In reply to Heiko Tietze from comment #3)
> Do we save the grid color in the document? Doubt this. IMO not supported.
> 
> (Not sure why exactly my patch prevents this, haven't touched a filter.)

This came up yesterday while I was digging into the details of bug 158569 (and what our customer may really need there).
Saving and loading the grid color (as set on the global Calc - View page) was supported even in ods before this commit - probably it is still, just the UI was removed since (in bug 154446) and rendering broken in this commit.

My longer term idea would be to add sheet level settings (bug 158569) into some other dialog for compatibility (e.g. Page Style - Sheet), and have the current View page settings as defaults for new documents.

Comment 6 Gabor Kelemen (allotropia) 2023-12-07 14:17:36 UTC

Created attachment 191292 [details]
Colored grid example from Calc 7.4

Comment 7 Heiko Tietze 2024-01-22 12:45:50 UTC

It was an intentional change for bug 152184. If you store/apply the user-defined grid color it clashes with the automatically picked system color depending on bright/dark themes.