Bug 158802

Summary:	CRASH: deleting sheet and undoing
Product:	LibreOffice	Reporter:	Xisco Faulí <xiscofauli>
Component:	Calc	Assignee:	Not Assigned <libreoffice-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aron.budea, buzea.bogdan, parisoplop, suokunlong, telesto, xiscofauli
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	24.8.0.0 alpha0+
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=140330 https://crashreport.libreoffice.org/stats/signature/static%20double%20%60anonymous%20namespace'::GetPercentile(const%20class%20std::vector%3Cdouble,std::allocator%3Cdouble%3E%20%3E%20&%20const,%20double)
Whiteboard:	target:24.8.0
Crash report or crash signature:	["static double `anonymous namespace'::GetPercentile(const class std::vector<double,std::allocator<double> > & const, double)"]	Regression By:	Paris Oplopoios
Bug Depends on:
Bug Blocks:	108912

Description Xisco Faulí 2023-12-21 08:46:38 UTC

Steps to reproduce:
1. Open attachment 105986 [details] from bug 83675
2. Delete sheet 'IMAGE'
3. Undo

-> Crash

Reproduced in

Version: 24.2.0.0.beta1+ (X86_64) / LibreOffice Community
Build ID: 0034d2ab9382da86340738137218791a4ccc9c90
CPU threads: 8; OS: Linux 6.1; UI render: default; VCL: gtk3
Locale: fr-FR (es_ES.UTF-8); UI: en-US
Calc: threaded

Comment 1 Xisco Faulí 2023-12-21 08:47:21 UTC

Regression introduced by:

author	offtkp <parisoplop@gmail.com>	2023-11-01 18:52:35 +0200
committer	Paris Oplopoios <parisoplop@gmail.com>	2023-11-01 20:17:01 +0100
commit edbc3a09edcf58a4738b4648811a065f3f55bc7c (patch)
tree f795b2a6d553c76026125cf4bf2b4075e0d774a6
parent c1c1fb5e1d6055459a8b393114ecfbc31f822d45 (diff)
sc: Don't end handleConditionalFormat early

Bisected with: bibisect-linux64-24.2

Comment 2 Kevin Suo 2024-03-03 14:52:12 UTC

I do not reproduce with latest master

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 78065e3798439dd790d1be5ac5c219477285c888
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: zh-CN (zh_CN.UTF-8); UI: zh-CN
Calc: threaded

Xisco Faulí would you retest?

Comment 3 Xisco Faulí 2024-03-04 10:16:22 UTC

Issue fixed by

author	Mike Kaganski <mike.kaganski@collabora.com>	2024-01-15 17:22:35 +0600
committer	Mike Kaganski <mike.kaganski@collabora.com>	2024-01-15 14:07:55 +0100
commit 96493091a80fb01c33ea9153b737fdc554de61f0 (patch)
tree 31e7b6b06ab01ffe81930b2d0ffbadd04e87eab6
parent 784efd860788b1cdbddd363abafe74b463e080f3 (diff)
tdf#140330: do not deduplicate conditional formatting in undo context

Comment 4 Commit Notification 2024-03-04 18:57:33 UTC

Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a08cc309529c7bded0e4898ef638ca7bdc8c140f

tdf#158802: sc_uicalc: Add unittest

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.