Bug 158863

Summary: Impress templates from Indonesian LO Community do not contain README files
Product: LibreOffice Reporter: Laurent Balland <jumbo4444>
Component: ImpressAssignee: Laurent Balland <jumbo4444>
Status: RESOLVED FIXED    
Severity: minor CC: heiko.tietze, ilmari.lauhakangas
Priority: medium    
Version: 7.2.0.4 release   
Hardware: All   
OS: All   
Whiteboard: target:24.8.0
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 103314    

Description Laurent Balland 2023-12-26 08:30:57 UTC 
Description:
Indonesian LO Community introduced some templates (Candy, Freshes, Grey Elegant, Growing Liberty, Yellow Idea). Authors add a README file in each one (except Yellow Idea) which are available in source code, but not in the embedded template that users have access.

Steps to Reproduce:
1. Check source code for README files in presnt folder [1]
There are 4 files for Candy, Freshes, Grey Elegant and Growing Liberty templates
2. In your installation folder [2], unzip the corresponding template files


[1] https://opengrok.libreoffice.org/search?&path=README+presnt&project=core&sort=fullpath
[2] instdir/share/template/common/presnt/

Actual Results:
OTP files contain no README files

Expected Results:
OTP files should contain the README files


Reproducible: Always


User Profile Reset: Yes

Additional Info:
Missing files:
- /core/extras/source/templates/presnt/Candy/README.txt
- /core/extras/source/templates/presnt/Freshes/README.md
- /core/extras/source/templates/presnt/Grey_Elegant/README.txt
- /core/extras/source/templates/presnt/GROWING_Liberty/readme.txt

These should be uniformed and add to OTP files or remove from code.
Comment 1 Laurent Balland 2023-12-28 12:46:06 UTC 
I suggest to move the content of these README files to description tag  in meta.xml so that they easily appear for user in File > Properties > Description > Comments, like for Grey Elegant template (since LibO24.2.0 beta1)

@Heiko, do you think it make sense?
Comment 2 Heiko Tietze 2024-01-02 10:29:03 UTC 
+1 from my side. Ilmari, what do you think?
Comment 3 Commit Notification 2024-01-02 12:01:50 UTC 
Laurent Balland committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4f6143ac17cd36f33828136d2b1e3dbd5833e30c

tdf#158863 Move README to meta.xml

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2024-01-07 11:39:39 UTC 
Ilmari Lauhakangas committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4fe9fab476c5e7d4e56696e237e1b4034989c156

tdf#158863 Remove obsolete readme.txt file from Growing Liberty template

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.