| Summary: | Find Record: Similarities dialog won't appear | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Robert Großkopf <robert> |
| Component: | Base | Assignee: | Caolán McNamara <caolan.mcnamara> |
| Status: | VERIFIED FIXED | ||
| Severity: | major | CC: | caolan.mcnamara, hmeeks4135, jcsanz, serval2412, szymon.klos, xiscofauli |
| Priority: | high | Keywords: | bibisected, bisected, haveBacktrace, regression |
| Version: | 7.6.0.3 release | ||
| Hardware: | x86-64 (AMD64) | ||
| OS: | Linux (All) | ||
| Whiteboard: | target:24.8.0 target:7.6.5 target:24.2.0.2 | ||
| Crash report or crash signature: | Regression By: | Hannah Meeks | |
| Attachments: | bt with debug symbols | ||
|
Description
Robert Großkopf
2024-01-02 07:28:17 UTC
Confirmed with: ----------------- Version: 7.6.4.1 (X86_64) / LibreOffice Community Build ID: e19e193f88cd6c0525a17fb7a176ed8e6a3e2aa1 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded ---------------- Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 7d08767b890e723cd502b1c61d250924f695eb98 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded Also confirmed the similarity button works with: ---------- Version: 7.5.6.2 (X86_64) / LibreOffice Community Build ID: f654817fb68d6d4600d7d2f6b647e47729f55f15 CPU threads: 16; OS: Windows 10.0 Build 22631; UI render: Skia/Vulkan; VCL: win Locale: es-ES (es_ES); UI: es-ES Calc: CL threaded ----------- Created attachment 191728 [details]
bt with debug symbols
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=36343165c251e30c700360cc5c4266f576d4ac00 cui: Make SimilaritySearch dialog async and enable use for jsdialog Reverting the changes in cui/source/dialogs/cuifmsearch.cxx locally fixes the crash. (In reply to Julien Nabet from comment #3) > Regression from > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=36343165c251e30c700360cc5c4266f576d4ac00 > cui: Make SimilaritySearch dialog async and enable use for jsdialog > > Reverting the changes in cui/source/dialogs/cuifmsearch.cxx locally fixes > the crash. Hi Caolán, Since this issue is about async dialogs, I thought you might be interested I can help here Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/30f4044ff45403b7f69df4f49c3d58ccc8b3fdce Resolves: tdf#158965 Find Record: Similarities dialog doesn't appear It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-6": https://git.libreoffice.org/core/commit/5a731afcaa717bdabb5bebd1e625984c89ec601f Resolves: tdf#158965 Find Record: Similarities dialog doesn't appear It will be available in 7.6.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/fcf940f5c480160cf837ff1a84a988605b882bf2 Resolves: tdf#158965 Find Record: Similarities dialog doesn't appear It will be available in 24.2.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. With master sources updated today (so with Caolán's patch), I don't reproduce the assertion and get the dialog appear. Thank you Caolán! |