Bug 159193

Summary: Page orientation lost on redo
Product: LibreOffice Reporter: Telesto <telesto>
Component: WriterAssignee: Not Assigned <libreoffice-bugs>
Status: NEW ---    
Severity: normal CC: ilmari.lauhakangas
Priority: medium    
Version: 24.8.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard:
Crash report or crash signature: Regression By:
Bug Depends on:    
Bug Blocks: 105537    

Description Telesto 2024-01-15 13:27:10 UTC 
Description:
Page orientation lost on redo

Steps to Reproduce:
1. Open attachment 164872 [details] (bug 145374 and bug 136284)
2. Place cursor above Table 3.1a on page 2
3. Select content until bottom (say shift page down)
4. CTRL+N
5. CTRL+V and scroll to top (page orientation OK)
6. CTRL+Z
7. CTRL+Y Page orientation lost

Actual Results:
Page orientation not restored by redo

Expected Results:
Should be the case


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 25276df12abd9d002f7f899900434617b256f745
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL threaded
Comment 1 Buovjaga 2024-01-25 16:59:53 UTC 
Repro

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: ef6083200a4f28e43198c7a0878da6f4b880725f
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Comment 2 Buovjaga 2024-01-25 17:14:52 UTC 
By the way, for me the orientation is already lost with undo. And between step 3 and 4 should be Ctrl+C.

With a debug build it crashes at undo with

soffice.bin: /home/user/libreoffice/sw/source/core/txtnode/ndtxt.cxx:5494: void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint &): Assertion `dynamic_cast<SwTextFormatColl const*>(static_cast<const SwFormatChg*>(pOldValue)->pChangedFormat)' failed.
Comment 3 Buovjaga 2024-02-01 10:58:10 UTC 
(In reply to Buovjaga from comment #2)
> By the way, for me the orientation is already lost with undo. And between
> step 3 and 4 should be Ctrl+C.
> 
> With a debug build it crashes at undo with
> 
> soffice.bin: /home/user/libreoffice/sw/source/core/txtnode/ndtxt.cxx:5494:
> void SwTextNode::TriggerNodeUpdate(const sw::LegacyModifyHint &): Assertion
> `dynamic_cast<SwTextFormatColl const*>(static_cast<const
> SwFormatChg*>(pOldValue)->pChangedFormat)' failed.

Reported as bug 159503