Bug 159221

Summary: Color Scheme names not showing in gtk3
Product: LibreOffice Reporter: Rafael Lima <rafael.palma.lima>
Component: BASICAssignee: Rafael Lima <rafael.palma.lima>
Status: RESOLVED FIXED    
Severity: normal CC: caolan.mcnamara, serval2412, xiscofauli
Priority: medium    
Version: 24.8.0.0 alpha0+   
Hardware: All   
OS: All   
Whiteboard: target:24.8.0
Crash report or crash signature: Regression By:
Attachments: Screenshot showing the problem
bt

Description Rafael Lima 2024-01-16 13:26:21 UTC 
Created attachment 191995 [details]
Screenshot showing the problem

When using gtk3, the color scheme names in the Basic IDE do not show in the new Color Schemes dialog. All works well under gen and kf5.

Steps to reproduce:
1) Make sure you're using the gtk3 VCL plugin (SAL_USE_VCLPLUGIN=gtk3) and open any LO app
2) Open the Basic IDE (Tools - Macros - Edit macros)
3) Open the Color Scheme dialog (View - Color Scheme)
4) Notice that the color scheme names do not show; they can be clicked and they work fine, but you cannot read them

Testing with kf5 and gen works fine.

Code pointer: The list is populated in ColorSchemeDialog::Init()

System info:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 7850a7deb59b890c73dfd52bd5aced6a538e6349
CPU threads: 16; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: pt-BR (pt_BR.UTF-8); UI: en-US
Calc: CL threaded
Comment 1 Rafael Lima 2024-01-16 13:30:54 UTC 
@Caolan, any idea what might be happening here?
Comment 2 Julien Nabet 2024-01-17 13:17:57 UTC 
On pc Debian x86-64 with master sources updated today, I could reproduce this with gtk3.

I noticed this log several times:
warn:sfx.view:46450:46450:sfx2/source/view/viewsh.cxx:3321: SfxViewShell::GetColorConfigColor not overridden!
Comment 3 Julien Nabet 2024-01-17 13:18:46 UTC 
Created attachment 192017 [details]
bt

I retrieved a bt from the message log location.
Comment 4 Rafael Lima 2024-01-17 19:03:00 UTC 
Proposed patch here:
https://gerrit.libreoffice.org/c/core/+/162215
Comment 5 Caolán McNamara 2024-01-17 19:44:41 UTC 
yeah, treeviews are hard :-( To keep gtk(3) and gen happy there is basically just one pattern of (list|tree)store + cell renderers supported. Which is implicit for vcl and needs to be explicit for gtk. Ideally we'd have some asserts or build-time checks for this.
Comment 6 Commit Notification 2024-01-18 08:52:29 UTC 
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/950af5a45723d16cc5e91324f021a2e77470f2ce

tdf#159221 Fix color scheme names under Gtk3 (Basic IDE)

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Xisco Faulí 2024-01-18 09:08:39 UTC 
I believe this is master only