Bug 159572

Summary:	Insert special character dialog should regard font of recent characters on single click
Product:	LibreOffice	Reporter:	Oliver Specht (CIB) <oliver.specht>
Component:	Writer	Assignee:	Oliver Specht (CIB) <oliver.specht>
Status:	VERIFIED FIXED
Severity:	normal	CC:	kelemeng, stephane.guillou, vsfoote
Priority:	medium
Version:	7.6.3.2 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=155957 https://bugs.documentfoundation.org/show_bug.cgi?id=160246
Whiteboard:	target:24.8.0 target:24.2.1
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	109232

Description Oliver Specht (CIB) 2024-02-05 13:17:39 UTC

- Open the Insert special character dialog.
- select the font 'Wingdings' 
- select the aiplane character (hex U+F051) and press 'Insert'
->The airplane is inserted.

Now move the cursor within the document to a text that uses a normal font, e.g. Liberation Sans and open the dialog again.

Press the airplane in the 'Recent Characters' and the press Insert
->Instead of the airplane a greek letter theta is inserted

Depending on the os and the installed fonts the results could be different.

The 'Recent characters' store the character and the font of previously inserted characters. 
A double click inserts those characters directly and applies the previously used  font.

A single click shows the selected character in the preview box.
A click to the 'Insert' button inserts the character with the font selected in the 'Font' ComboBox instead of the previously used font.

Comment 1 V Stuart Foote 2024-02-05 14:18:37 UTC

And that is mishandling/misuse of Private Use area of a symbol font.

U+F051 is from the Unicode PUA and has no meaning other than for the font it was selected from. The Recents and Favorites in fact will record the source font and Unicode--but system may or maynot honor and falls back. 

Question would be how to warn folks NOT to use PUA glyphs in their documents.

For this example, Unicode U+2708 from the DINGBATS block would be the more reliable glyph to use. How to encourage selecting the more reliable glyph(s) from the SCD?

Comment 2 Commit Notification 2024-02-08 17:48:20 UTC

Oliver Specht committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cbcf22eb8748d59857b29a8792377a10fc6c42b2

tdf#159572 select font according to recent settings

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 3 Commit Notification 2024-02-09 00:38:39 UTC

Oliver Specht committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/e4ef509f3fea0c99708c111d731365b3225575d2

tdf#159572 select font according to recent settings

It will be available in 24.2.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Gabor Kelemen (allotropia) 2024-02-16 10:12:14 UTC

Looks good to me in master.

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 125fc2ce861c82592b261f2992c893b414396e56
CPU threads: 6; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: threaded

Comment 5 Stéphane Guillou (stragu) 2024-02-28 12:02:30 UTC

Thanks for this fix, Oliver, much appreciated.
Verified in:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a1a1d8edb9d4a62b747aa7069b3026e2ba75704d
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded