| Summary: | 17 Noto Fonts dropped from 24.2 bundle without notice (and 1 added) | ||
|---|---|---|---|
| Product: | LibreOffice | Reporter: | Jim DeLaHunt <from+documentfoundation> |
| Component: | LibreOffice | Assignee: | Xisco Faulí <xiscofauli> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | normal | CC: | khaled, serval2412, telesto, xiscofauli |
| Priority: | medium | ||
| Version: | 24.2.0.3 release | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=124591 https://bugs.documentfoundation.org/show_bug.cgi?id=152396 |
||
| Whiteboard: | |||
| Crash report or crash signature: | Regression By: | ||
|
Description
Jim DeLaHunt
2024-02-17 04:22:54 UTC
Khaled: thought you might be interested in this one. At least NotoMono-Regular.ttf was explicitly removed in https://git.libreoffice.org/core/+/739ee655294be56021dc6244dde3faa75e288bd5%5E%21 Re-adding the NotoSans* and NotoSerif* ones in https://gerrit.libreoffice.org/c/core/+/163825. the NotoSansArabicUI* and NotoNaskhArabicUI* ones doesn't seem to exist upstream anymore Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/aa49b95cd1bb2baa357c9aac7e5d046630ffac85 tdf#159752: Add missing NotoSans/NotoSerif fonts back It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/73bec7219024319caf9898b7d2ab94feeb877a62 tdf#159752: Add missing NotoSans/NotoSerif fonts back It will be available in 24.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Dropped fonts info added to the release notes: https://wiki.documentfoundation.org/ReleaseNotes/24.2#Feature_Removal_/_Deprecation Thanks for the detailed report! Thank you for the response! Is it appropriate to add to the release notes an explanation for why those fonts were dropped? I was thinking about making an edit to the wiki page https://wiki.documentfoundation.org/ReleaseNotes/24.2#Feature_Removal_/_Deprecation with this. But maybe the release notes page is not the place for explanation. Also, it would be nice to mention the added font in the Release Notes. Should I go ahead and do that? How can I find the commit or bug documenting this addition? Finally, would it be appropriate of me to note these font changes in the Fonts wiki page https://wiki.documentfoundation.org/Fonts#List_of_fonts_in_LibreOffice ? We can’t use condensed font style in LibreOffice (bug 152396), so it is just dead weight. Light and other non-R/B/I/BI styles are not consistently handled in LibreOffice across platforms (bug 35538), so a document using one on Windows will render with fallback font on macOS and vice versa, so also not a good idea to bundle font styles we can’t consistently handle. We bundle way too many font files, so it seemed to be a good idea to trim it a bit by dropping problematic styles. The commit messages should have mentioned all of this, so that is on me. (In reply to خالد حسني from comment #8) > We can’t use condensed font style in LibreOffice (bug 152396), so it is just > dead weight. Light and other non-R/B/I/BI styles are not consistently > handled in LibreOffice across platforms (bug 35538), so a document using one > on Windows will render with fallback font on macOS and vice versa, so also > not a good idea to bundle font styles we can’t consistently handle. We > bundle way too many font files, so it seemed to be a good idea to trim it a > bit by dropping problematic styles. The commit messages should have > mentioned all of this, so that is on me. Thanks for the information Khaled. I'll revert my patch then. Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4114b916102d7df76f7a59b4d82435d9ab0ffec6 Revert "tdf#159752: Add missing NotoSans/NotoSerif fonts back" It will be available in 24.8.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/cc2a6503e62103e8767108d064774639d1d9f34f Revert "tdf#159752: Add missing NotoSans/NotoSerif fonts back" It will be available in 24.2.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Adapting status FWIW... I might be wrong, but I think that the differences when rendering Noto fonts was with version 1. At least some of those problems were supposed to be solved with the very latest versions (2.xxx). Please don't just take my word; this needs to be actually tested. Regarding the Noto Mono fonts in version 1, they were replaced in the newer versions with Noto Sans Mono. Additionally, the newer versions of Noto fonts come in 2 variants, static and variable, respectively. |