Bug 159918

Summary:	A11Y sidebar: Tabs used in TOC create warning
Product:	LibreOffice	Reporter:	Gabor Kelemen (allotropia) <kelemeng>
Component:	Writer	Assignee:	Samuel Mehrbrodt (allotropia) <samuel.mehrbrodt>
Status:	RESOLVED FIXED
Severity:	normal	CC:	samuel.mehrbrodt, stephane.guillou
Priority:	medium	Keywords:	accessibility
Version:	7.5.0.3 release
Hardware:	All
OS:	All
Whiteboard:	target:24.8.0 target:24.2.3
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	89606, 154929
Attachments:	Example file from Writer with tabs in TOC How the tab is used in the TOC, with the sidebar warning

Description Gabor Kelemen (allotropia) 2024-02-27 01:47:53 UTC

Created attachment 192810 [details]
Example file from Writer with tabs in TOC

In the TOC it is possible to add Tab characters as separators between the parts of the TOC entries.
The Accessibility sidebar gives a warning about these, as if they were in the text - but it is not needed.

1. Open attached document
2. Open the Accessibility sidebar
->Warning about tabs, which were added to the TOC

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 74185b8edf7f046a3372319da86a1d8ca0024c87
CPU threads: 15; OS: Windows 10.0 Build 19045; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: default

Seems to have started in 7.5, with the initial addition of the test for tabs:
https://git.libreoffice.org/core/+/3c0be5564afe1b9cc843a49aba88b72af74c43ab

author	Paris Oplopoios <paris.oplopoios@collabora.com>	Mon Oct 24 14:12:44 2022 +0300
committer	Tomaž Vajngerl <quikee@gmail.com>	Wed Nov 09 23:54:58 2022 +0100

a11y: Add check for tabs used for formatting

Comment 1 Gabor Kelemen (allotropia) 2024-02-27 01:48:22 UTC

Created attachment 192811 [details]
How the tab is used in the TOC, with the sidebar warning

Comment 2 Stéphane Guillou (stragu) 2024-03-13 04:20:11 UTC

Reproduced:

Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: f42363c51672a5b3685b0b9b11e932680530dce3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Three warnings for sample files. Even if it was warranted, it should be just one.

Comment 3 Commit Notification 2024-03-28 09:44:16 UTC

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c6075e716200e9c6bae1b10be2cf10013958e83a

tdf#159918 a11y check: Don't warn about tabs in ToC

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Commit Notification 2024-03-31 20:38:25 UTC

Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/7a61065bb8ccf33fb1918218bf2febd30e786bf4

tdf#159918 a11y check: Don't warn about tabs in ToC

It will be available in 24.2.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.