Bug 160282

Summary:	Ranges references text colors for in-cell editing of formulas are too dark for dark mode, causing low contrast
Product:	LibreOffice	Reporter:	Jeff Fortin Tam <nekohayo>
Component:	Calc	Assignee:	Heiko Tietze <heiko.tietze>
Status:	RESOLVED FIXED
Severity:	normal	CC:	heiko.tietze, rafael.palma.lima
Priority:	medium	Keywords:	accessibility
Version:	24.2.0.3 release
Hardware:	All
OS:	All
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=38304 https://bugs.documentfoundation.org/show_bug.cgi?id=159530
Whiteboard:	target:24.8.0
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	59284, 108253, 153293
Attachments:	Screenshot from LibreOffice Calc in dark mode New colors

Description Jeff Fortin Tam 2024-03-19 22:58:28 UTC

Created attachment 193206 [details]
Screenshot from LibreOffice Calc in dark mode

As you can see in the attached screenshot, most of the automatic cell border colors for cells/ranges references in formulas, when you are editing a formula "within the canvas/cell" by double-clicking a cell, are not appropriate for LibreOffice's dark mode.

They should be lighter variants of those colors in order to ensure enough contrast with the dark background.

--------------------------------------------------

Version: 24.2.1.2 (X86_64) / LibreOffice Community
Build ID: db4def46b0453cc22e2d0305797cf981b68ef5ac
CPU threads: 8; OS: Linux 6.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Flatpak
Calc: threaded

Comment 1 Rafael Lima 2024-03-20 11:46:44 UTC

From all I know, these colors are hardcoded in:

/core/sc/source/ui/app/rfindlst.cxx

Maybe they should be configurable?

Comment 2 Jeff Fortin Tam 2024-03-20 14:50:01 UTC

I would not recommend* making those colors configurable.
I believe they should simply have light vs dark variants "designed to work".

This advice of mine would also apply to the "see also" issues above,
and to bug #160160, bug #160159, bug #158032, etc.

*: …for the reasons presented here: https://youtube.com/watch?v=rRvmS0mABC0

Comment 3 Heiko Tietze 2024-03-21 10:52:48 UTC

Agree with another hard-coded set. Quick and dirty patch at https://gerrit.libreoffice.org/c/core/+/165095

Comment 4 Heiko Tietze 2024-03-21 10:53:25 UTC

Created attachment 193224 [details]
New colors

Using "Light blue/red/orange/green 3" from the standard palette

Comment 5 Commit Notification 2024-03-22 12:06:49 UTC

Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c8b240e7cad6ef74e16ad83d45957737389aa90

Resolves tdf#160282 - Ranges references text colors for dark backgrounds

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.