Bug 161133

Summary:	Date field in Table Control's read-only column can be edited with date picker
Product:	LibreOffice	Reporter:	Stéphane Guillou (stragu) <stephane.guillou>
Component:	Base	Assignee:	Caolán McNamara <caolan.mcnamara>
Status:	VERIFIED FIXED
Severity:	normal	CC:	caolan.mcnamara
Priority:	medium	Keywords:	bibisected, bisected, regression
Version:	7.1.0.0.alpha0+
Hardware:	All
OS:	Linux (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=141633 https://bugs.documentfoundation.org/show_bug.cgi?id=160882
Whiteboard:	target:24.8.0 target:24.2.4
Crash report or crash signature:		Regression By:	Caolán McNamara
Bug Depends on:
Bug Blocks:	108440

Description Stéphane Guillou (stragu) 2024-05-16 13:21:44 UTC

Steps:
1. Open attachment 193905 [details]
2. Right-click on Formcontrols form > Edit
3. In the Table Control, right-click on BirthDate column > Column
4. In the General tab, set "Enabled=Yes" and "Read-only=Yes"
5. Turn Design Mode off
6. Open the calendar popover in the BirthDate column, double-click on a date

Result: even though the column is read-only, dates can still be changed.

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 658a212585c56540a17c41111e6829716d4ef4e3
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

Same with gen VCL plugin.

Bibisected with linux-64-7.1 repo to first bad build [339870fa2c32f7cb5c77273f2c54e08070e30cfa] which points to:

commit 6e7e19d9c300dbdd279789b09f94781e946fad52
author	Caolán McNamara 	Wed Jul 15 12:10:32 2020 +0100
committer	Caolán McNamara 	Tue Jul 21 10:25:42 2020 +0200
weld DateControl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98858

Caolán can you please have a look?

Comment 1 Robert Großkopf 2024-05-16 13:36:17 UTC

Could confirm the buggy behavior with

Version: 24.2.3.2 (X86_64) / LibreOffice Community
Build ID: 433d9c2ded56988e8a90e6b2e771ee4e6a5ab2ba
CPU threads: 6; OS: Linux 6.4; UI render: default; VCL: kf5 (cairo+xcb)
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

… and also LO 7.1.0.3 (oldest version here with this behavior on OpenSUSE 15.6 64bit rpm Linux)

Comment 2 Caolán McNamara 2024-05-17 20:39:35 UTC

https://gerrit.libreoffice.org/c/core/+/167802 should fix that

Comment 3 Commit Notification 2024-05-18 14:35:45 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/29ec8099d078182ea461e278c13d4ab869ae3cd9

Resolves: tdf#161133 read-only widget should have deactivated calendar

It will be available in 24.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 4 Caolán McNamara 2024-05-18 19:20:32 UTC

done in trunk, backport to 24.2 in gerrit

Comment 5 Commit Notification 2024-05-19 18:34:03 UTC

Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-24-2":

https://git.libreoffice.org/core/commit/7472bf01dee87a45aa3345397ae6f072f5d57058

Resolves: tdf#161133 read-only widget should have deactivated calendar

It will be available in 24.2.4.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.

Comment 6 Stéphane Guillou (stragu) 2024-06-03 12:24:54 UTC

Thanks Caolán, verified in:

Version: 24.8.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 1f15d097cace14ca6e44e7652f460aa3fa7bd150
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded